nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-25 01:02:24 +00:00
Code Issues Projects Releases Wiki Activity

Add a missing conf_copy in gtkapp's Duplicate Session.

Browse Source 
Without this, the Conf objects in a session and its duplicate were
aliases of each other, which could lead to confusing semantic effects
if one of the sessions was reconfigured in mid-run, and worse still, a
crash if one session got cleaned up and called conf_free on a Conf
that the other was still using.

None of that was intentional; it was just a matter of forgetting to
clone the Conf for the duplicated session. Now we do.
This commit is contained in:
Simon Tatham 2017-11-25 21:51:45 +00:00
parent 116dac29cc
commit 5b13a1b015
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
unix/gtkapp.c
View File

@ -196,7 +196,7 @@ void launch_duplicate_session(Conf *conf)
{ {
extern const int dup_check_launchable; extern const int dup_check_launchable;
assert(!dup_check_launchable || conf_launchable(conf)); assert(!dup_check_launchable || conf_launchable(conf));
new_session_window(conf, NULL); new_session_window(conf_copy(conf), NULL);
} }
void launch_new_session(void) void launch_new_session(void)