nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-05-28 15:24:49 -05:00
Code Issues Projects Releases Wiki Activity

Stop calling gdk_input_add() with a zero flags word. If we don't

Browse Source 
want to know about any input events on a socket, it's simpler not to
call gdk_input_add() on it at all.

I hesitate to say `fixes', but ... this change _causes to go away_
the weird problem I had with blank host key dialogs. I have no
understanding of the chain of cause and effect between gdk_input_add
with zero flags and missing redraw events, but it seems like a
change I should make anyway, so I'm going to do so and hope the
problem doesn't come back :-/

[originally from svn r7164]
This commit is contained in:
Simon Tatham 2007-01-26 07:28:55 +00:00
parent 5d3306f98d
commit 65f9735b95
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
unix/GTK2.TODO
View File

@ -40,9 +40,6 @@ Items from Colin's original mail:
Other items:
- The host key security alert dialog box is coming up the right
size but totally blank! Find out why and fix it.
- Since Colin's patch was originally prepared I committed r7117
(fold up treeview branches at depth 2 or greater), and this is
not currently replicated in the GTK2 version of the treeview

8
unix/gtkwin.c
View File

@ -2695,11 +2695,15 @@ int uxsel_input_add(int fd, int rwx) {
if (rwx & 1) flags |= GDK_INPUT_READ;
if (rwx & 2) flags |= GDK_INPUT_WRITE;
if (rwx & 4) flags |= GDK_INPUT_EXCEPTION;
return gdk_input_add(fd, flags, fd_input_func, NULL);
if (flags)
return gdk_input_add(fd, flags, fd_input_func, NULL);
else
return -1;
}
void uxsel_input_remove(int id) {
gdk_input_remove(id);
if (id > 0)
gdk_input_remove(id);
}
char *guess_derived_font_name(GdkFont *font, int bold, int wide)