nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-03-22 06:38:37 -05:00
Code Issues Projects Releases Wiki Activity

Use sgrowarray_nm in GetDlgItemText_alloc

Browse Source 
GetDlgItemText_alloc is often used to get passwords from text fields,
so the memory should be freed and erased properly. Otherwise parts
of passwords might leak in memory.

Signed-off-by: Sven Strickroth <email@cs-ware.de>
This commit is contained in:
Sven Strickroth 2019-03-19 08:39:08 +01:00 committed by Simon Tatham
parent 7631875d41
commit 674219b115
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
windows/winutils.c
View File

@ -163,7 +163,7 @@ char *GetDlgItemText_alloc(HWND hwnd, int id)
size_t size = 0; size_t size = 0;
do { do {
sgrowarray(ret, size, size); sgrowarray_nm(ret, size, size);
GetDlgItemText(hwnd, id, ret, size); GetDlgItemText(hwnd, id, ret, size);
} while (!memchr(ret, '\0', size-1)); } while (!memchr(ret, '\0', size-1));