nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-03-22 14:39:24 -05:00
Code Issues Projects Releases Wiki Activity

Don't reject _and_ accept X forwarding requests!

Browse Source 
If a sharing downstream asks for an auth method we don't understand,
we should send them CHANNEL_FAILURE *and then stop processing*. Ahem.

(Spotted while examining this code in the course of Coverity-related
fixes, but not itself a Coverity-found problem.)
This commit is contained in:
Simon Tatham 2014-11-22 09:59:37 +00:00
parent 90dcef3d9e
commit 69d50b2877
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sshshare.c
View File

@ -1672,6 +1672,8 @@ static void share_got_pkt_from_downstream(struct ssh_sharing_connstate *cs,
PUT_32BIT(recipient_id, chan->downstream_id); PUT_32BIT(recipient_id, chan->downstream_id);
send_packet_to_downstream(cs, SSH2_MSG_CHANNEL_FAILURE, send_packet_to_downstream(cs, SSH2_MSG_CHANNEL_FAILURE,
recipient_id, 4, NULL); recipient_id, 4, NULL);
sfree(auth_data);
break;
} }
chan->x11_auth_proto = auth_proto; chan->x11_auth_proto = auth_proto;