From 71f409f088046059ac025836ad0993adc957231a Mon Sep 17 00:00:00 2001 From: Jacob Nevins Date: Fri, 2 Sep 2022 22:30:59 +0100 Subject: [PATCH] Enable -Wall in Windows STRICT builds. This has been missing since the cmake transition (c19e7215dd) -- mkfiles.pl generally used at least -Wall -Werror -Wvla with GCC-like compilers. After that, Windows STRICT gained -Wpointer-arith, but lost -Wall and hence a lot of other warnings (such as the -Wformat I muttered about in baea34a5b2). My mingw-w64 build survives this (after my recent warning fixes), and apparently an official Bob build does too. --- cmake/platforms/windows.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/platforms/windows.cmake b/cmake/platforms/windows.cmake index 0e1e6150..f8ab8597 100644 --- a/cmake/platforms/windows.cmake +++ b/cmake/platforms/windows.cmake @@ -104,7 +104,7 @@ endif() if(STRICT AND (CMAKE_C_COMPILER_ID MATCHES "GNU" OR CMAKE_C_COMPILER_ID MATCHES "Clang")) - set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror -Wpointer-arith -Wvla") + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Werror -Wpointer-arith -Wvla") endif() if(CMAKE_C_COMPILER_ID MATCHES "MSVC")