nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-10 09:58:01 +00:00
Code Issues Projects Releases Wiki Activity

Don't try sending on sharing channels.

Browse Source 
The final main loop in do_ssh2_authconn will sometimes loop over all
currently open channels calling ssh2_try_send_and_unthrottle. If the
channel is a sharing one, however, that will reference fields of the
channel structure like 'remwindow', which were never initialised in
the first place (thanks, valgrind). Fix by excluding CHAN_SHARING
channels from that loop.
This commit is contained in:
Simon Tatham 2015-06-07 21:14:09 +01:00
parent 0b2f283622
commit 7366fde1d4
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ssh.c
View File

@ -10524,6 +10524,7 @@ static void do_ssh2_authconn(Ssh ssh, const unsigned char *in, int inlen,
* Try to send data on all channels if we can. * Try to send data on all channels if we can.
*/ */
for (i = 0; NULL != (c = index234(ssh->channels, i)); i++) for (i = 0; NULL != (c = index234(ssh->channels, i)); i++)
if (c->type != CHAN_SHARING)
ssh2_try_send_and_unthrottle(ssh, c); ssh2_try_send_and_unthrottle(ssh, c);
} }
} }