nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-03-16 03:53:01 -05:00
Code Issues Projects Releases Wiki Activity

Vyacheslav Andrejev points out a heap management goof in the new jump

Browse Source 
list code. Free the old value of the pointer variable we just
overwrote, not the new one!

[originally from svn r9062]
This commit is contained in:
Simon Tatham 2010-12-29 13:35:44 +00:00
parent 6538793a72
commit 7dab9e5573
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
windows/winstore.c
View File

@ -699,8 +699,8 @@ static int transform_jumplist_registry
ret = RegSetValueEx(pjumplist_key, reg_jumplist_value, 0, REG_MULTI_SZ, ret = RegSetValueEx(pjumplist_key, reg_jumplist_value, 0, REG_MULTI_SZ,
new_value, piterator_new - new_value); new_value, piterator_new - new_value);
sfree(old_value);
old_value = new_value; old_value = new_value;
sfree(new_value);
} else } else
ret = ERROR_SUCCESS; ret = ERROR_SUCCESS;