nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-04-21 21:15:03 -05:00
Code Issues Projects Releases Wiki Activity

Uppity X forwarding: fix SockAddr use after free.

Browse Source 
Another thing pointed out by ASan: new_unix_listener takes ownership
of the SockAddr you give it, so I shouldn't have been freeing it at
the end of platform_make_x11_server().
This commit is contained in:
Simon Tatham 2019-01-23 20:50:49 +00:00
parent e7edc6e7ba
commit 891c2b9616
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
unix/ux_x11.c
View File

@ -201,8 +201,7 @@ int platform_make_x11_server(Plug *plug, const char *progname, int mindisp,
out: out:
if (a_tcp) if (a_tcp)
sk_addr_free(a_tcp); sk_addr_free(a_tcp);
if (a_unix) /* a_unix doesn't need freeing, because new_unix_listener took it over */
sk_addr_free(a_unix);
sfree(authfilename); sfree(authfilename);
strbuf_free(authfiledata); strbuf_free(authfiledata);
sfree(unix_path); sfree(unix_path);