nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-07-02 03:52:49 -05:00
Code Issues Projects Releases Wiki Activity

Giant const-correctness patch of doom!

Browse Source 
Having found a lot of unfixed constness issues in recent development,
I thought perhaps it was time to get proactive, so I compiled the
whole codebase with -Wwrite-strings. That turned up a huge load of
const problems, which I've fixed in this commit: the Unix build now
goes cleanly through with -Wwrite-strings, and the Windows build is as
close as I could get it (there are some lingering issues due to
occasional Windows API functions like AcquireCredentialsHandle not
having the right constness).

Notable fallout beyond the purely mechanical changing of types:
 - the stuff saved by cmdline_save_param() is now explicitly
   dupstr()ed, and freed in cmdline_run_saved.
 - I couldn't make both string arguments to cmdline_process_param()
   const, because it intentionally writes to one of them in the case
   where it's the argument to -pw (in the vain hope of being at least
   slightly friendly to 'ps'), so elsewhere I had to temporarily
   dupstr() something for the sake of passing it to that function
 - I had to invent a silly parallel version of const_cmp() so I could
   pass const string literals in to lookup functions.
 - stripslashes() in pscp.c and psftp.c has the annoying strchr nature
This commit is contained in:
Simon Tatham
2015-05-15 11:15:42 +01:00
parent fb4fbe1158
commit 89da2ddf56
65 changed files with 559 additions and 450 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
macosx/osxmain.m
View File

@ -58,7 +58,7 @@ char *x_get_default(const char *key)
return NULL; /* this is a stub */
}
static void commonfatalbox(char *p, va_list ap)
static void commonfatalbox(const char *p, va_list ap)
{
char errorbuf[2048];
NSAlert *alert;
@ -85,7 +85,7 @@ static void commonfatalbox(char *p, va_list ap)
exit(1);
}
void nonfatal(void *frontend, char *p, ...)
void nonfatal(void *frontend, const char *p, ...)
{
char *errorbuf;
NSAlert *alert;
@ -103,7 +103,7 @@ void nonfatal(void *frontend, char *p, ...)
sfree(errorbuf);
}
void fatalbox(char *p, ...)
void fatalbox(const char *p, ...)
{
va_list ap;
va_start(ap, p);
@ -111,7 +111,7 @@ void fatalbox(char *p, ...)
va_end(ap);
}
void modalfatalbox(char *p, ...)
void modalfatalbox(const char *p, ...)
{
va_list ap;
va_start(ap, p);
@ -119,7 +119,7 @@ void modalfatalbox(char *p, ...)
va_end(ap);
}
void cmdline_error(char *p, ...)
void cmdline_error(const char *p, ...)
{
va_list ap;
fprintf(stderr, "%s: ", appname);