nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-10 01:48:00 +00:00
Code Issues Projects Releases Wiki Activity

Use a strbuf in ssh_ecdhkex_m_setup.

Browse Source 
This removes the one remaining failure at -Wvla. (Of course, that
array isn't for a _hash_ function, so it wouldn't have been quite
appropriate to make it a static array of size MAX_HASH_LEN.)
This commit is contained in:
Simon Tatham 2019-01-02 22:01:38 +00:00
parent 53f0ce3d0c
commit 8d6d7a3615
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
sshecc.c
View File

@ -1269,15 +1269,15 @@ static void ssh_ecdhkex_w_setup(ecdh_key *dh)
static void ssh_ecdhkex_m_setup(ecdh_key *dh) static void ssh_ecdhkex_m_setup(ecdh_key *dh)
{ {
unsigned char bytes[dh->curve->fieldBytes]; strbuf *bytes;
for (size_t i = 0; i < sizeof(bytes); ++i) for (size_t i = 0; i < dh->curve->fieldBytes; ++i)
bytes[i] = random_byte(); put_byte(bytes, random_byte());
bytes[0] &= 0xF8; bytes->u[0] &= 0xF8;
bytes[dh->curve->fieldBytes-1] &= 0x7F; bytes->u[bytes->len-1] &= 0x7F;
bytes[dh->curve->fieldBytes-1] |= 0x40; bytes->u[bytes->len-1] |= 0x40;
dh->private = mp_from_bytes_le(make_ptrlen(bytes, dh->curve->fieldBytes)); dh->private = mp_from_bytes_le(ptrlen_from_strbuf(bytes));
smemclr(bytes, sizeof(bytes)); strbuf_free(bytes);
dh->m_public = ecc_montgomery_multiply(dh->curve->m.G, dh->private); dh->m_public = ecc_montgomery_multiply(dh->curve->m.G, dh->private);
} }