nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-07-11 16:23:55 -05:00
Code Issues Projects Releases Wiki Activity

Add lots of missing 'static' keywords.

Browse Source 
A trawl through the code with -Wmissing-prototypes and
-Wmissing-variable-declarations turned up a lot of things that should
have been internal to a particular source file, but were accidentally
global. Keep the namespace clean by making them all static.

(Also, while I'm here, a couple of them were missing a 'const': the
ONE and ZERO arrays in sshcrcda.c, and EMPTY_WINDOW_TITLE in
terminal.c.)
This commit is contained in:
Simon Tatham
2020-01-29 06:22:01 +00:00
parent 787181bb12
commit 8d747d8029
21 changed files with 46 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
unix/gtkdlg.c
View File

@ -3279,14 +3279,14 @@ static void messagebox_handler(union control *ctrl, dlgparam *dp,
dlg_end(dp, ctrl->generic.context.i);
}
const struct message_box_button button_array_yn[] = {
static const struct message_box_button button_array_yn[] = {
{"Yes", 'y', +1, 1},
{"No", 'n', -1, 0},
};
const struct message_box_buttons buttons_yn = {
button_array_yn, lenof(button_array_yn),
};
const struct message_box_button button_array_ok[] = {
static const struct message_box_button button_array_ok[] = {
{"OK", 'o', 1, 1},
};
const struct message_box_buttons buttons_ok = {