From 97a248b463d49a47418532cd5797f6ea7773a4cf Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Sat, 3 Mar 2018 18:20:04 +0000 Subject: [PATCH] Use gdk_display_beep() in place of obsolete gdk_beep(). Except in GTK1 (which doesn't have the former), via a gtkcompat.h workaround. Up-to-date GTK3 has deprecated gdk_beep(), causing build failures due to the default -Werror setting. --- unix/gtkcompat.h | 1 + unix/gtkdlg.c | 4 ++-- unix/gtkwin.c | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/unix/gtkcompat.h b/unix/gtkcompat.h index ae25d7f5..43a3181c 100644 --- a/unix/gtkcompat.h +++ b/unix/gtkcompat.h @@ -66,6 +66,7 @@ #define gtk_adjustment_set_step_increment(a, val) ((a)->step_increment = (val)) #define gtk_adjustment_get_value(a) ((a)->value) #define gtk_selection_data_get_selection(a) ((a)->selection) +#define gdk_display_beep(disp) gdk_beep() #define gtk_widget_set_has_window(w, b) \ gtk1_widget_set_unset_flag(w, GTK_NO_WINDOW, !(b)) diff --git a/unix/gtkdlg.c b/unix/gtkdlg.c index a7efd3b4..119c428c 100644 --- a/unix/gtkdlg.c +++ b/unix/gtkdlg.c @@ -1040,7 +1040,7 @@ void dlg_set_focus(union control *ctrl, void *dlg) */ void dlg_beep(void *dlg) { - gdk_beep(); + gdk_display_beep(gdk_display_get_default()); } static void set_transient_window_pos(GtkWidget *parent, GtkWidget *child) @@ -1452,7 +1452,7 @@ static void draglist_move(struct dlgparam *dp, struct uctrl *uc, int direction) if ((index < 0) || (index == 0 && direction < 0) || (index == g_list_length(children)-1 && direction > 0)) { - gdk_beep(); + gdk_display_beep(gdk_display_get_default()); return; } diff --git a/unix/gtkwin.c b/unix/gtkwin.c index d170fad7..314db770 100644 --- a/unix/gtkwin.c +++ b/unix/gtkwin.c @@ -3349,7 +3349,7 @@ void sys_cursor(void *frontend, int x, int y) void do_beep(void *frontend, int mode) { if (mode == BELL_DEFAULT) - gdk_beep(); + gdk_display_beep(gdk_display_get_default()); } int char_width(Context ctx, int uc)