nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-10 01:48:00 +00:00
Code Issues Projects Releases Wiki Activity

Bah! Nicolas Barry correctly points out that my async agent code

Browse Source 
simply doesn't work - if multiple concurrent agent requests are
attempted, some of them will fail for no apparent reason. I assume
concurrent SendMessage() calls don't work in the Windows API, or
some such. So I'm commenting out the async code for the moment
(there wasn't a Windows Pageant that made helpful use of it anyway
yet) and returning to the drawing board.

[originally from svn r3756]
This commit is contained in:
Simon Tatham 2004-01-21 21:11:03 +00:00
parent 1527565ad7
commit 98d735fde4
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pageantc.c
View File

@ -26,6 +26,13 @@ int agent_exists(void)
return TRUE; return TRUE;
} }
/*
* Unfortunately, this asynchronous agent request mechanism doesn't
* appear to work terribly well. I'm going to comment it out for
* the moment, and see if I can come up with a better one :-/
*/
#ifdef WINDOWS_ASYNC_AGENT
struct agent_query_data { struct agent_query_data {
COPYDATASTRUCT cds; COPYDATASTRUCT cds;
unsigned char *mapping; unsigned char *mapping;
@ -63,6 +70,8 @@ DWORD WINAPI agent_query_thread(LPVOID param)
return 0; return 0;
} }
#endif
int agent_query(void *in, int inlen, void **out, int *outlen, int agent_query(void *in, int inlen, void **out, int *outlen,
void (*callback)(void *, void *, int), void *callback_ctx) void (*callback)(void *, void *, int), void *callback_ctx)
{ {
@ -89,6 +98,7 @@ int agent_query(void *in, int inlen, void **out, int *outlen,
cds.dwData = AGENT_COPYDATA_ID; cds.dwData = AGENT_COPYDATA_ID;
cds.cbData = 1 + strlen(mapname); cds.cbData = 1 + strlen(mapname);
cds.lpData = mapname; cds.lpData = mapname;
#ifdef WINDOWS_ASYNC_AGENT
if (callback != NULL && !(flags & FLAG_SYNCAGENT)) { if (callback != NULL && !(flags & FLAG_SYNCAGENT)) {
/* /*
* We need an asynchronous Pageant request. Since I know of * We need an asynchronous Pageant request. Since I know of
@ -111,6 +121,7 @@ int agent_query(void *in, int inlen, void **out, int *outlen,
return 0; return 0;
sfree(data); sfree(data);
} }
#endif
/* /*
* The user either passed a null callback (indicating that the * The user either passed a null callback (indicating that the