nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-10 09:58:01 +00:00
Code Issues Projects Releases Wiki Activity

Fix null dereference in ssh_unthrottle.

Browse Source 
The backend_unthrottle function gets called when the backlog on stdout
clears, and it's possible for that to happen _after_ the SSH backend
has terminated the connection and freed all its protocol modules (e.g.
if a protocol error occurred on the network while data was still
waiting to be written to stdout). So ssh_unthrottle should check that
ssh->cl still exists before calling any method of it.
This commit is contained in:
Simon Tatham 2019-01-29 20:31:47 +00:00
parent 0212b9e5e5
commit a5911f76d0
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ssh.c
View File

@ -1013,7 +1013,8 @@ static void ssh_unthrottle(Backend *be, int bufsize)
{ {
Ssh *ssh = container_of(be, Ssh, backend); Ssh *ssh = container_of(be, Ssh, backend);
ssh_stdout_unthrottle(ssh->cl, bufsize); if (ssh->cl)
ssh_stdout_unthrottle(ssh->cl, bufsize);
} }
static bool ssh_connected(Backend *be) static bool ssh_connected(Backend *be)