nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-07-01 11:32:48 -05:00
Code Issues Projects Releases Wiki Activity

Add some missing casts in ctype functions.

Browse Source 
I thought I'd found all of these before, but perhaps a few managed to
slip in since I last looked. The character argument to the <ctype.h>
functions must have the value of an unsigned char or EOF; passing an
ordinary char (unless you know char is unsigned on every platform the
code will ever go near) risks mistaking '\xFF' for EOF, and causing
outright undefined behaviour on byte values in the range 80-FE. Never
do it.
This commit is contained in:
Simon Tatham
2023-03-05 13:15:57 +00:00
parent 259de04636
commit a76109c586
6 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
windows/utils/split_into_argv.c
View File

@ -173,7 +173,7 @@ void split_into_argv(char *cmdline, bool includes_program_name,
* First deal with the simplest of all special cases: if there
* aren't any arguments, return 0,NULL,NULL.
*/
while (*cmdline && isspace(*cmdline)) cmdline++;
while (*cmdline && isspace((unsigned char)*cmdline)) cmdline++;
if (!*cmdline) {
if (argc) *argc = 0;
if (argv) *argv = NULL;
@ -195,7 +195,7 @@ void split_into_argv(char *cmdline, bool includes_program_name,
bool quote;
/* Skip whitespace searching for start of argument. */
while (*p && isspace(*p)) p++;
while (*p && isspace((unsigned char)*p)) p++;
if (!*p) break;
/*
@ -240,7 +240,7 @@ void split_into_argv(char *cmdline, bool includes_program_name,
/* Copy data into the argument until it's finished. */
while (*p) {
if (!quote && isspace(*p))
if (!quote && isspace((unsigned char)*p))
break; /* argument is finished */
if (*p == '"' || (*p == '\\' && backslash_special)) {