From a82e1da0b7d503e53a1d53fb40cdac0284fc104e Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Mon, 2 Mar 2020 18:43:00 +0000 Subject: [PATCH] Fix GUI config crash due to missing Ed448. How embarrassing - this morning's triumphant push of a shiny new public-key method managed to break the entire GUI configuration system so that it dereferences a null pointer during setup. That's what I get for only testing the crypto side. settings.c generates a preference list of host-key enum values that included HK_ED448. So then hklist_handler() in config.c tries to look that id up in its list of names, and doesn't find one, because I forgot to add it there. Now reinstated. --- config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/config.c b/config.c index 8c02cf6e..f42a99ec 100644 --- a/config.c +++ b/config.c @@ -505,6 +505,7 @@ static void hklist_handler(union control *ctrl, dlgparam *dlg, static const struct { const char *s; int k; } hks[] = { { "Ed25519", HK_ED25519 }, + { "Ed448", HK_ED448 }, { "ECDSA", HK_ECDSA }, { "DSA", HK_DSA }, { "RSA", HK_RSA },