nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-10 09:58:01 +00:00
Code Issues Projects Releases Wiki Activity

Fix indentation goof in CRC test suite.

Browse Source 
In crypt.testCRC32(), I had intended to test every input byte with
each of several previous states, but I mis-indented what should have
been the inner loop (over bytes), with the effect that instead I
silently tested the input bytes with only the last of those states.
This commit is contained in:
Simon Tatham 2019-04-12 23:39:43 +01:00
parent 4cbb0bae65
commit b5597cc833
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/cryptsuite.py
View File

@ -998,13 +998,13 @@ class crypt(MyTestBase):
for prior in test_prior_values: for prior in test_prior_values:
prior_shifted = shift8(prior) prior_shifted = shift8(prior)
for i in range(256): for i in range(256):
exp = shift8(i) ^ prior_shifted exp = shift8(i) ^ prior_shifted
self.assertEqual(crc32_update(prior, struct.pack("B", i)), exp) self.assertEqual(crc32_update(prior, struct.pack("B", i)), exp)
# Check linearity of the _reference_ implementation, while # Check linearity of the _reference_ implementation, while
# we're at it! # we're at it!
self.assertEqual(shift8(i ^ prior), exp) self.assertEqual(shift8(i ^ prior), exp)
def testCRCDA(self): def testCRCDA(self):
def pattern(badblk, otherblks, pat): def pattern(badblk, otherblks, pat):