mirror of
https://git.tartarus.org/simon/putty.git
synced 2025-07-03 20:42:48 -05:00
Move echo/edit state change functionality out of ldisc_send.
I'm not actually sure why we've always had back ends notify ldisc of changes to echo/edit settings by giving ldisc_send(ldisc,NULL,0,0) a special meaning, instead of by having a separate dedicated notify function with its own prototype and parameter set. Coverity's recent observation that the two kinds of call don't even have the same requirements on the ldisc (particularly, whether ldisc->term can be NULL) makes me realise that it's really high time I separated the two conceptually different operations into actually different functions. While I'm here, I've renamed the confusing ldisc_update() function which that special operation ends up feeding to, because it's not actually a function applying to an ldisc - it applies to a front end. So ldisc_send(ldisc,NULL,0,0) is now ldisc_echoedit_update(ldisc), and that in turn figures out the current echo/edit settings before passing them on to frontend_echoedit_update(). I think that should be clearer.
This commit is contained in:
11
psftp.c
11
psftp.c
@ -2506,16 +2506,7 @@ void connection_fatal(void *frontend, char *fmt, ...)
|
||||
cleanup_exit(1);
|
||||
}
|
||||
|
||||
void ldisc_send(void *handle, char *buf, int len, int interactive)
|
||||
{
|
||||
/*
|
||||
* This is only here because of the calls to ldisc_send(NULL,
|
||||
* 0) in ssh.c. Nothing in PSFTP actually needs to use the
|
||||
* ldisc as an ldisc. So if we get called with any real data, I
|
||||
* want to know about it.
|
||||
*/
|
||||
assert(len == 0);
|
||||
}
|
||||
void ldisc_echoedit_update(void *handle) { }
|
||||
|
||||
/*
|
||||
* In psftp, all agent requests should be synchronous, so this is a
|
||||
|
Reference in New Issue
Block a user