nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-10 01:48:00 +00:00
Code Issues Projects Releases Wiki Activity

bignum_set_bit: Don't abort if asked to clear an inaccessible bit

Browse Source 
All those bits are clear anyway.

Bug found with the help of afl-fuzz.

(cherry picked from commit 4f34059902)
This commit is contained in:
Ben Harris 2015-10-11 09:27:55 +01:00 committed by Simon Tatham
parent 07af4ed100
commit d03024905e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sshbn.c
View File

@ -1202,9 +1202,9 @@ int bignum_bit(Bignum bn, int i)
*/ */
void bignum_set_bit(Bignum bn, int bitnum, int value) void bignum_set_bit(Bignum bn, int bitnum, int value)
{ {
if (bitnum < 0 || bitnum >= (int)(BIGNUM_INT_BITS * bn[0])) if (bitnum < 0 || bitnum >= (int)(BIGNUM_INT_BITS * bn[0])) {
abort(); /* beyond the end */ if (value) abort(); /* beyond the end */
else { } else {
int v = bitnum / BIGNUM_INT_BITS + 1; int v = bitnum / BIGNUM_INT_BITS + 1;
BignumInt mask = (BignumInt)1 << (bitnum % BIGNUM_INT_BITS); BignumInt mask = (BignumInt)1 << (bitnum % BIGNUM_INT_BITS);
if (value) if (value)