From d78d14f917d11deb9418fbd96a1ee05c1315c234 Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Sat, 29 Jan 2022 18:19:58 +0000 Subject: [PATCH] HTTP proxy: fix nonsense HTTP version check. Substitution of && for || would have caused us to accept HTTP/1.0 when we meant to reject it. Thanks Coverity! --- proxy/http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxy/http.c b/proxy/http.c index f788e52c..081fefb6 100644 --- a/proxy/http.c +++ b/proxy/http.c @@ -479,7 +479,7 @@ static void proxy_http_process_queue(ProxyNegotiator *pn) crStopV; } - if (maj_ver < 1 && (maj_ver == 1 && min_ver < 1)) { + if (maj_ver < 1 || (maj_ver == 1 && min_ver < 1)) { /* Before HTTP/1.1, connections close by default */ s->connection_close = true; }