From e0b811cc1f3b5ec5d8cb6868afac9a26da4221c5 Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Sat, 6 Jul 2019 18:05:54 +0100 Subject: [PATCH] ssh2userauth: fix sense of test for change_username! How embarrassing: we were looping back round to prompt for a username again if s->change_username was *true*, but then the test at the top would only have reissued the prompt if it was *false*. So that configuration checkbox must have been broken for ages. It's a good job most SSH servers don't reward enabling it! --- ssh2userauth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ssh2userauth.c b/ssh2userauth.c index 01eaae60..24b237c2 100644 --- a/ssh2userauth.c +++ b/ssh2userauth.c @@ -392,7 +392,7 @@ static void ssh2_userauth_process_queue(PacketProtocolLayer *ppl) /* * Get a username. */ - if (s->got_username && s->change_username) { + if (s->got_username && !s->change_username) { /* * We got a username last time round this loop, and * with change_username turned off we don't try to get