From ef7a821bb19e657179cad5a383f3991c39a1c527 Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Sat, 2 Apr 2016 14:12:12 +0100 Subject: [PATCH] 64-bit cleanness: fix a couple of format strings in winjump.c. strcspn() returns a size_t, which is not safe to pass as the parameter in a printf argument list corresponding to a "*" field width specifier in the format string, because the latter should be int, which may not be the same size as size_t. --- windows/winjump.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/windows/winjump.c b/windows/winjump.c index eca5041a..e5bca935 100644 --- a/windows/winjump.c +++ b/windows/winjump.c @@ -445,7 +445,8 @@ static IShellLink *make_shell_link(const char *appname, sessionname, "'", NULL); } else { assert(appname); - desc_string = dupprintf("Run %.*s", strcspn(appname, "."), appname); + desc_string = dupprintf("Run %.*s", + (int)strcspn(appname, "."), appname); } ret->lpVtbl->SetDescription(ret, desc_string); sfree(desc_string); @@ -461,7 +462,8 @@ static IShellLink *make_shell_link(const char *appname, pv.pszVal = dupstr(sessionname); } else { assert(appname); - pv.pszVal = dupprintf("Run %.*s", strcspn(appname, "."), appname); + pv.pszVal = dupprintf("Run %.*s", + (int)strcspn(appname, "."), appname); } pPS->lpVtbl->SetValue(pPS, &PKEY_Title, &pv); sfree(pv.pszVal);