From f13f9f642005cdd23d262dec263d36bbe34cc22f Mon Sep 17 00:00:00 2001 From: Jacob Nevins Date: Wed, 22 Dec 2004 23:17:02 +0000 Subject: [PATCH] Fix potential access of freed data (only if we couldn't create the second of two registry keys, so pretty unlikely). [originally from svn r5021] --- windows/winstore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/windows/winstore.c b/windows/winstore.c index f454f172..743283f6 100644 --- a/windows/winstore.c +++ b/windows/winstore.c @@ -82,13 +82,14 @@ void *open_settings_w(const char *sessionname, char **errmsg) return NULL; } ret = RegCreateKey(subkey1, p, &sesskey); - sfree(p); RegCloseKey(subkey1); if (ret != ERROR_SUCCESS) { *errmsg = dupprintf("Unable to create registry key\n" "HKEY_CURRENT_USER\\%s\\%s", puttystr, p); + sfree(p); return NULL; } + sfree(p); return (void *) sesskey; }