nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-25 01:02:24 +00:00
Code Issues Projects Releases Wiki Activity

Fix a Windows warning on a strange cast.

Browse Source 
The specific thing that's strange about it is that it's _not_ an error
even though the compiler is quite justified in being suspicious about
it! The MS APIs define two different structures to have identical
formats.
This commit is contained in:
Simon Tatham 2018-06-03 14:53:29 +01:00
parent 6142013abc
commit f1fae1bfaa
1 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
windows/wingss.c
View File

@ -369,8 +369,23 @@ static void localexp_to_exp_lifetime(TimeStamp *localexp,
if (expiry)
*expiry = GSS_NO_EXPIRATION;
if (!LocalFileTimeToFileTime(localexp, &expUTC))
return;
/*
* Type oddity: localexp is a pointer to 'TimeStamp', whereas
* LocalFileTimeToFileTime expects a pointer to FILETIME. However,
* despite having different formal type names from the compiler's
* point of view, these two structures are specified to be
* isomorphic in the MS documentation, so it's legitimate to copy
* between them:
*
* https://msdn.microsoft.com/en-us/library/windows/desktop/aa380511(v=vs.85).aspx
*/
{
FILETIME localexp_ft;
enum { vorpal_sword = 1 / (sizeof(*localexp) == sizeof(localexp_ft)) };
memcpy(&localexp_ft, localexp, sizeof(localexp_ft));
if (!LocalFileTimeToFileTime(&localexp_ft, &expUTC))
return;
}
TIME_WIN_TO_POSIX(expUTC, exp);
delta = exp - now;