nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-10 09:58:01 +00:00
Code Issues Projects Releases Wiki Activity

Jacob reports a segfault when using HTTP proxying under Minefield.

Browse Source 
It appears that this is because Visual C's sscanf works by first
calling strlen to get the length of the string, so that its internal
read-character routine can be sure of never overrunning the buffer.
Quite why the internal read-char routine can't detect \0 _itself_
rather than having to have it found for it in advance I have no
idea. Sigh.

[originally from svn r3844]
This commit is contained in:
Simon Tatham 2004-02-10 19:07:45 +00:00
parent f1d532e2d0
commit f41b9c6304
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
proxy.c
View File

@ -590,8 +590,14 @@ int proxy_http_negotiate (Proxy_Socket p, int change)
/* get the status line */ /* get the status line */
len = bufchain_size(&p->pending_input_data); len = bufchain_size(&p->pending_input_data);
assert(len > 0); /* or we wouldn't be here */ assert(len > 0); /* or we wouldn't be here */
data = snewn(len, char); data = snewn(len+1, char);
bufchain_fetch(&p->pending_input_data, data, len); bufchain_fetch(&p->pending_input_data, data, len);
/*
* We must NUL-terminate this data, because Windows
* sscanf appears to require a NUL at the end of the
* string because it strlens it _first_. Sigh.
*/
data[len] = '\0';
eol = get_line_end(data, len); eol = get_line_end(data, len);
if (eol < 0) { if (eol < 0) {