1
0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-10 18:07:59 +00:00
Commit Graph

1024 Commits

Author SHA1 Message Date
Simon Tatham
08c1ca1936 Oops - changing the prototype of statictext() affected puttygen.c too
[originally from svn r1256]
2001-09-09 10:35:56 +00:00
Simon Tatham
d27684019b Roman Pompejus's patch (heavily hacked) for parametric log file
names with date, time and hostname automatically embedded.

[originally from svn r1255]
2001-09-09 09:58:20 +00:00
Simon Tatham
b5dcdf7fc8 Fix potential float screwup in scp percentage indicator. (Don't
compute (100*a)/b. Instead compute 100*(a/b), because that way
there's no chance that 100*a will become inexact enough to fail to
yield 100 when a==b.)

[originally from svn r1254]
2001-09-08 15:16:30 +00:00
Simon Tatham
b12f450964 Jacob's TIS / CCard authentication tweaks.
[originally from svn r1253]
2001-09-08 12:50:15 +00:00
Simon Tatham
51eeeae237 Jan Holmen Holsten's patch for drag-selects to scroll the scrollback.
[originally from svn r1252]
2001-09-08 12:37:48 +00:00
Simon Tatham
a3bfa43b0f Fix error message: couldn't load _private_ key, not public.
[originally from svn r1251]
2001-09-08 11:57:00 +00:00
Simon Tatham
2e4cefa420 When we receive SSH_MSG_DISCONNECT, say so in an error box because
it's likely to be more helpful than `Strange packet received' or
whatever.

[originally from svn r1250]
2001-09-08 10:33:56 +00:00
Simon Tatham
c1e38248b1 Fix to link_font() from RDB. I must get him to comment some of this :-)
[originally from svn r1249]
2001-09-07 23:02:07 +00:00
Simon Tatham
ea788e29c7 RDB also points out we don't need the CJK `not recommended for
general use' wcwidth function, so we condition it out to save space.

[originally from svn r1248]
2001-09-07 23:00:37 +00:00
Simon Tatham
8692657fdd Patch from RDB: Markus Kuhn has issued an updated version of his
wcwidth function.

[originally from svn r1247]
2001-09-07 22:59:07 +00:00
Simon Tatham
5768c6700d Another patch from RDB: prevent luni_send from sending a particular
range of Unicode characters. Not entirely sure I understand this one
but I trust that RDB knows what he's talking about with Unicode.

[originally from svn r1246]
2001-09-07 22:58:00 +00:00
Simon Tatham
97a2c907db RDB points out that when you memset a newly allocated structure to
zero, covering the size of the _structure_ rather than the size of
the pointer to it might help :-)

[originally from svn r1245]
2001-09-07 22:52:51 +00:00
Simon Tatham
e2c086b090 RDB's session logging patch: due to some ghastly special case, UTF-8
characters that failed the UTF-8 canonicality rules were being sent
to the session log twice. Sounds trivial, but I bet it'd have
confused anyone who turned on session logging precisely to track
down a canonicality bug :-)

[originally from svn r1244]
2001-09-07 22:51:52 +00:00
Simon Tatham
3c74c01014 Pedantry patch from RDB: sanitise header use, correct one comment
and remove an unused variable.

[originally from svn r1243]
2001-09-07 22:49:17 +00:00
Simon Tatham
eebec27c99 Patch from RDB: in the case where the protocol read from the
settings file is unrecognised (i.e. PuTTYtel reading PuTTY's
registry), fall back to the default _port_ as well as the default
protocol.

[originally from svn r1242]
2001-09-07 22:45:05 +00:00
Simon Tatham
e1ecb1c61e Patch from RDB: fix the failure to display window-resize pointers
when in raw mouse mode.

[originally from svn r1241]
2001-09-07 22:43:31 +00:00
Simon Tatham
0a2950f834 Patch from RDB: rename ISO-8859-12 to -13, add ISO-8859-16, and
update the year specifications on some of the ISO-8859 names.

[originally from svn r1240]
2001-09-07 22:41:38 +00:00
Simon Tatham
f08de20a1e Robert de Bath's asynchronous-connect patch. Helps a lot in port
forwarding; improves Event Log; and causes the PuTTY window to
appear earlier in the setup process.

[originally from svn r1239]
2001-09-07 22:39:01 +00:00
Simon Tatham
47e97ae032 Fix gratuitous assertion failure in Plink (ssh1_throttle_count was
being decremented far too many times).

[originally from svn r1238]
2001-09-07 22:04:44 +00:00
Simon Tatham
f1c2f2fcf0 Robert de Bath's `Patch.a_alt_key': clean up the handling of
Alt-Space, Alt-only and the System menu. It lets Windows do more of
the work, and also saves a static variable, so it must be good :-)

[originally from svn r1237]
2001-09-07 21:39:03 +00:00
Simon Tatham
8e58b47df2 Use WM_SETREDRAW to disable incremental updates while the config box
is switching panels. Speeds things up hugely on slow systems.

[originally from svn r1236]
2001-09-07 21:07:15 +00:00
Simon Tatham
5fad95e748 Jacob's patch to cause Shift to return to copy-and-paste when xterm
mouse tracking is enabled. (This can be turned off if your app
really wants Shift+mouse, but it defaults to on for general
usefulness.)

[originally from svn r1235]
2001-09-07 20:35:38 +00:00
Simon Tatham
fdb6435ef9 Oops, fix that fix. TranslateKey can return <0 and it needs to be
dealt with. I don't recall being told that; I should comment it at
some stage.

[originally from svn r1234]
2001-09-07 20:32:33 +00:00
Simon Tatham
e65095f52b Fix mouse hiding on keypresses, which was failing due to the Unicode
patch having done something bizarre to the semantics of TranslateKey.

[originally from svn r1233]
2001-09-07 20:18:55 +00:00
Simon Tatham
25c58b71d1 Fix the intermittent fault in the socket layer that was occasionally
bombing out X forwarding. It turns out to be a workaround for YET
ANOTHER useless WinSock implementation. Arrgh!

[originally from svn r1232]
2001-09-05 22:04:19 +00:00
Simon Tatham
c6346dce42 Swap round the contents of the Translation panel. The codepage box
should be at the top because it's by _far_ the most important.

[originally from svn r1231]
2001-09-05 21:02:27 +00:00
Simon Tatham
12e7195c0e Unicode cleanup phase 2: we now reintroduce the ability to enter a
numeric code page, and also reinstate the direct-to-font zero
translation mode (but now under an actual _name_ rather than blank).
Also add CP437 to the list since at least one expatriate DOS user
wanted it; also select a sensible ISO or KOI codepage based on the
system locale.

[originally from svn r1230]
2001-09-05 21:01:04 +00:00
Simon Tatham
6dacf35120 Better yet, look for sftp-server on the user's PATH as well, which
allows individual users with shell access to install it without
reference to the admin.

[originally from svn r1229]
2001-09-05 19:58:25 +00:00
Simon Tatham
cb1aa5d0f3 PSFTP will now attempt to find /usr/[local]/lib/sftp-server if it
can't start the sftp subsystem. This should enable convenient sftp
access to SSH1-only systems: all the admin needs is to install
sftp-server in the right place.

[originally from svn r1228]
2001-09-05 19:48:52 +00:00
Simon Tatham
b27c27f657 When pscp in SFTP mode does client-side matching of a server-side
wildcard, it's polite to let the user know if the wildcard didn't
match any file names.

[originally from svn r1227]
2001-09-05 19:33:12 +00:00
Simon Tatham
1a1ed1ff71 Fix segfault (should free act.buf not act.name, because the latter
might not point at the start of the former). Cheers Minefield :-)

[originally from svn r1224]
2001-08-29 08:56:26 +00:00
Simon Tatham
c9326c240e stripslashes() should have been dealing with colons as well. I don't
_think_ there was an exploit (even if the server sends "c:foobar",
the client will not attempt to create "c:foobar"; instead it will
try to create ".\c:foobar" which will fail), but it's as well to be
sure.

[originally from svn r1223]
2001-08-28 12:26:16 +00:00
Simon Tatham
f143fff0db Semantic fix in the X11 `authentication failed' error packet
construction. Doesn't actually affect anything right now, since the
bug was a failure to round a length up to the next multiple of 4 and
it so happens that our current message was exactly 40 bytes anyway
:-) But if we start giving a wider variety of messages one day then
it might be handy to be able to do them without gratuitous crashes.

[originally from svn r1222]
2001-08-28 12:24:50 +00:00
Simon Tatham
bbc7f197bc Add documentation of the new PSCP `-unsafe' option and the
associated warning message.

[originally from svn r1221]
2001-08-28 09:53:51 +00:00
Simon Tatham
d1d2fd7a13 D'oh! Putting keyboard-interactive authentication _before_ publickey
causes password login to occur on a server that supports password-
through-k-i. Of course when we use the new preference list mechanism
for selecting the order of authentications this will all become much
more sane, but for the moment I've put publickey back up to the top
and things seem to be happier.

[originally from svn r1220]
2001-08-28 08:43:33 +00:00
Simon Tatham
5c72d5adc5 Fix externally added SSH1 keys in Pageant. I have no idea how this
code _ever_ worked before! But it's been like this for four months
and nobody has noticed, including me. That's quite spooky.

[originally from svn r1219]
2001-08-28 08:36:27 +00:00
Simon Tatham
ea27f048f9 Fix various small compiler warnings, mostly unused local variables
[originally from svn r1218]
2001-08-28 08:08:43 +00:00
Simon Tatham
493d34c655 PuTTYgen: add an extra button to save a public key into a file
(as well as showing it for cut and paste). For SSH1, this feature is
largely cosmetic and added for orthogonality; it comes into its own
in SSH2, where it saves the Official One True Public Key Format as
specified in the draft spec, and more particularly as used by
ssh.com's product for authentication. Now that ssh-3.0.1 supports
RSA user keys, this is suddenly actually useful.

[originally from svn r1217]
2001-08-27 17:40:03 +00:00
Simon Tatham
5c646f3270 Fix handling of SSH2_MSG_CHANNEL_CLOSE, which was breaking in port
forwarding talking to ssh.com's ssh-3.0.1.

[originally from svn r1216]
2001-08-27 16:58:47 +00:00
Simon Tatham
4692974d7d Port forwarding update: local-host-only listening sockets are now
done properly (by binding to INADDR_LOOPBACK) instead of hackishly
(by binding to INADDR_ANY, looking at the peer address when a
connection is accepted, and slamming the connection shut at that
point).

[originally from svn r1215]
2001-08-27 15:59:37 +00:00
Simon Tatham
ac97a0cb1d Add a couple of missing return values
[originally from svn r1214]
2001-08-27 15:55:44 +00:00
Simon Tatham
254f50974e Port forwarding bug fix: we were unable to handle receiving
CHANNEL_OPEN_FAILURE messages, which occur when the remote side is
unable to open a forwarded network connection we have requested. (It
seems they _don't_ show up if you get something mundane like
Connection Refused - the channel is cheerfully opened and
immediately slammed shut - but they do if you try to connect to a
host that doesn't even exist. Try forwarding a port to
frogwibbler:4800 and see what you get.)

[originally from svn r1213]
2001-08-27 15:13:14 +00:00
Simon Tatham
448c1a085a Finally tighten up the server-side wildcard security hole, the
_right_ way. (SSWs are disabled by default and can be re-enabled
using `-unsafe', meaning that pscp will _never_ do anything
unexpected to your local file system unless you explicitly give
consent. The sftp-based variant will work fine because the
corresponding mechanism is _not_ unsafe.)

[originally from svn r1212]
2001-08-27 15:02:52 +00:00
Simon Tatham
a8e0abbf28 Fix tiny bug in new sftp-mode wildcards: when there wasn't a leading
path component (just `host:*' rather than `host:directory/*') there
was trouble.

[originally from svn r1211]
2001-08-27 14:51:31 +00:00
Simon Tatham
e6c8913093 Minor modification: in remote->local non-recursive mode matching a
wildcard, we don't abandon ship completely if the wildcard matches a
directory; we just warn and carry on with the rest.

[originally from svn r1210]
2001-08-27 10:24:55 +00:00
Simon Tatham
0da98d052d Implemented a simple wildcard matching engine, and used it to
restore remote wildcard capability in sftp-style PSCP.

[originally from svn r1209]
2001-08-27 10:17:41 +00:00
Simon Tatham
ff9a038cdd PSCP now uses the modern SFTP protocol if it can, and falls back to
scp1 if it can't. Currently not very tested - I checked it in as
soon as it completed a successful recursive copy in both directions.
Also, one known bug: you can't specify a remote wildcard, because by
the nature of SFTP we'll need to implement the wildcard engine on
the client side. I do intend to do this (and use the same wildcard
engine in PSFTP as well) but I haven't got round to it yet.

[originally from svn r1208]
2001-08-26 18:32:28 +00:00
Simon Tatham
605fa91201 Arrgh; yet again I make my security checking too draconian to
actually get things done. I'm sure this is the second time I've
checked in this mistake :-/ Still, this time I've got right to the
bottom of the cause, and commented it clearly. Phew.

[originally from svn r1207]
2001-08-26 15:45:55 +00:00
Simon Tatham
ebde798f13 Oops. ^X^S comes _before_ `cvs commit'. Two more diagnostics gone :-)
[originally from svn r1206]
2001-08-26 15:32:51 +00:00
Simon Tatham
306a13c025 Further tightening up in PSCP. Fixed a couple more holes whereby a
malicious SCP server could have written to areas other than the ones
the user requested; cleared up buffer overruns everywhere. Hopefully
we now do not use arbitrary buffer limits _anywhere_.

[originally from svn r1205]
2001-08-26 15:31:29 +00:00