1
0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-10 09:58:01 +00:00
Commit Graph

1890 Commits

Author SHA1 Message Date
Simon Tatham
c42085dc89 Various cosmetic fixes to the GTK config box: vertical alignment of
edit box labels, Left/Right on the treeview to collapse and expand
branches, a window title, and the best treatment of wrapping text
widgets I could think of within the product-order-oriented GTK
layout model. I think this thing is now pretty much as good as it's
going to get before GTK v2 (which should fix one or two remaining
minor nasties which I really couldn't be bothered to work around in
GTK 1.2), so the next step is to actually start _using_ it.

[originally from svn r2979]
2003-03-22 17:00:06 +00:00
Simon Tatham
ba7148c42b The GTK colour selector does not provide full 8-bit resolution in
the RGB values (it deals in floats with 2 d.p. instead). Hence I've
replaced the static RGB text item in the Colours panel with three
little edit boxes, so that a user can type in exact 0-255 RGB values
if necessary. This should have the additional advantage of being
quicker than faffing with the colour selector if you already know
exactly what you want and are in a hurry!

[originally from svn r2978]
2003-03-22 11:07:59 +00:00
Simon Tatham
271adc266d Fiddle with the cmdline_saved mechanism: the `-load' option is now
never deferred, but is evaluated instantly. This _should_ fix all
the irritating problems with (for example) proxy settings and saved
sessions not playing nicely. Or it may have some other ghastly side-
effect I haven't considered; really I ought to have been keeping
better track of all the problems in this area :-(

[originally from svn r2976]
2003-03-22 10:36:28 +00:00
Simon Tatham
17bafa0c08 Windows file selectors contain an edit box as well as the Browse
button; we must send EVENT_VALCHANGE when the edit box is manually
changed as well as when the file selector successfully completes.

[originally from svn r2975]
2003-03-22 10:05:10 +00:00
Simon Tatham
a185d54301 Yikes - saving of Default Settings must have been broken for some
time! The load code in settings.c was translating an empty string
into "Default Settings" to pass to {win,ux}store, whereas the save
code was passing the empty string straight down and expecting it to
be dealt with. So, a policy decision: the precise name of the
"Default Settings" special session _at the storage level_ is up to
the individual platform storage code to decide, and all platforms
MUST assume Default Settings is meant if they receive NULL or the
empty string as a session name.

[originally from svn r2974]
2003-03-22 09:49:20 +00:00
Simon Tatham
429fe02ac8 Make sure one of the Local/Remote port forwarding radio buttons
actually starts off selected!

[originally from svn r2973]
2003-03-22 09:32:49 +00:00
Simon Tatham
196fc3ea8d Fixed the bug whereby PuTTYgen went into generation mode as soon as
it started up. The problem was that I was accepting _any_ event on
IDC_GENERATE to trigger this, not just the `clicked' event, and some
uninteresting event like `initialise' must have occurred. Quite why
this only showed up as a result of the config box revamp I can't
imagine.

[originally from svn r2972]
2003-03-22 09:22:52 +00:00
Ben Harris
174b839586 Add crude support for multiple panels in the config dialogue box. There's
no way to switch between panels yet, though, so you're stuck on the first one.

[originally from svn r2971]
2003-03-21 00:24:17 +00:00
Ben Harris
ba8c8fec9c Pass a pointer to the entire dialog box structure to event handlers, rather
than just the individual control pointer, because otherwise event handlers
can't modify other controls.

[originally from svn r2970]
2003-03-20 23:15:25 +00:00
Ben Harris
fded7e88c2 Mention xterm mouse reporting in the section on copy and paste.
[originally from svn r2969]
2003-03-20 22:12:12 +00:00
Ben Harris
6d95dc84b4 Add support for drawing a ring around the default button in System 7.
[originally from svn r2967]
2003-03-19 00:40:15 +00:00
Ben Harris
ea3dd210de Add support for changing the contents of a pre-Appearance static text control.
[originally from svn r2966]
2003-03-18 23:47:33 +00:00
Ben Harris
471e004558 Tag the "Cancel" button appropriately, in case anyone's using a theme that
pays attention to it.

[originally from svn r2965]
2003-03-18 23:41:14 +00:00
Simon Tatham
3100306c90 Better appearance and positioning for dlg_error_msg box, and also
I've just found out that it's easy to ask for the config box to be
centred on the screen by default, which is kinda cool.

[originally from svn r2962]
2003-03-18 19:47:28 +00:00
Ben Harris
7f84c9f2da Change the token for HTTP Basic Authentication from "basic" to "Basic".
According to RFC 2617, it should be case-insensitive, but some proxies
(Microsoft Proxy Server in particular) erroneously reject "basic".
Should fix semi-bug msproxy-denied.

[originally from svn r2959]
2003-03-18 19:12:40 +00:00
Simon Tatham
4d41247cde Big sprawling dialog-box commit covering all sorts of things.
Buttons now have an `iscancel' flag to go with `isdefault';
dlg_last_focused() now explicitly passes the control it _doesn't_
care about (`I want the last control that had focus and isn't this
one'); and in the GTK implementation, various fixes have happened,
notably including arrow keys working sensibly in list boxes and the
treeview and short font aliases being expanded correctly to
initialise the font selectors.

[originally from svn r2958]
2003-03-18 19:06:51 +00:00
Simon Tatham
e2874c40c8 Gah, another duplicate keyword. I must stop creating new docs
sections by cut and paste.

[originally from svn r2956]
2003-03-18 09:03:31 +00:00
Ben Harris
893ca6173a My First CDEF: A terribly trivial static text control for System 7.
Needs work.

[originally from svn r2955]
2003-03-18 00:35:40 +00:00
Ben Harris
8978c74c45 Insert a missing ampersand that meant that the last version didn't even
compile.

[originally from svn r2954]
2003-03-17 22:38:18 +00:00
Ben Harris
53b61424bc Partial implementation of the platform-independent dialogue-box interface
for the Mac OS.  This isn't anywhere near complete, and is wrong in a few
important regards, but I think it's heading in the right direction.

[originally from svn r2953]
2003-03-17 21:40:37 +00:00
Ben Harris
cea3619ca9 If I() and S() aren't inline, provide a prototype even if we're defining
them.  This is useful for compilers that warn about un-prototyped functions.

[originally from svn r2952]
2003-03-17 21:36:13 +00:00
Ben Harris
93198194fb When running on a system with Aqua menu layout, delete the separator line
above "Quit" as well as "Quit" itself.

[originally from svn r2951]
2003-03-17 19:00:36 +00:00
Simon Tatham
13c7bf5dd5 Error messages update. It's now abundantly clear that WSAECONNABORTED
is not the same thing as ECONNABORTED, so I've removed the `we're a
bit confused about this, send us details' text. And someone has just
been confused by `connection timed out', so I've added that too.

[originally from svn r2950]
2003-03-17 16:57:23 +00:00
Jacob Nevins
082c3ac37f typo
[originally from svn r2948]
2003-03-16 20:18:11 +00:00
Simon Tatham
a954943023 RSA blinding requires random numbers. Hence, Pageant now needs to
have the random number generator linked in.

[originally from svn r2945]
2003-03-16 13:28:48 +00:00
Simon Tatham
f9f695b72a Further work on the GTK config box; mostly implemented keyboard
shortcuts now (only treeviews and list boxes to go, which currently
do very weird things and I need to overhaul them completely).

[originally from svn r2944]
2003-03-16 12:37:48 +00:00
Simon Tatham
b4e7ec8b12 Fixed accelerator clash in the Unix-specific config, since gtkdlg.c
is now competent to detect them :-)

[originally from svn r2943]
2003-03-16 12:36:33 +00:00
Simon Tatham
64e9abcbb1 My comment about RSA blinding was talking slight tosh. Fixed in case
anyone ever actually reads it :-)

[originally from svn r2942]
2003-03-15 18:39:10 +00:00
Simon Tatham
8ba003b9a0 Implement RSA blinding, to defeat Brumley and Boneh's RSA timing
attacks. In the PuTTY suite I'm pretty sure they're only applicable
to a forwarded Pageant, and if your remote sysadmin is abusing your
Pageant then you're shafted _anyway_; but it can't hurt to take
precautions now, just in case things change in future.

[originally from svn r2941]
2003-03-15 17:51:05 +00:00
Simon Tatham
d681abb508 When a piece of text overflows its column in a tabbed list box, I
think on balance I rather like the natural behaviour of the way I've
done it, except that non-zero separation between the columns would
be even nicer. Accordingly, here is some.

[originally from svn r2940]
2003-03-15 15:56:51 +00:00
Simon Tatham
d62f4f8cf6 The Telnet ENVIRON configurer also had a list box with an implicit
tab stop. Fixed this one too.

[originally from svn r2939]
2003-03-15 15:55:03 +00:00
Simon Tatham
6a67fdc0cc Event handling in the GTK dialog engine is now basically present and
correct. All the callbacks are getting called, all the dialog
actions are working (the port forwarding, colour and charclass
configurers are all completely functional), file, font and colour
selectors happen, and it's all looking pretty cool.

[originally from svn r2938]
2003-03-15 15:50:42 +00:00
Simon Tatham
097fbefa82 Windows sets automatic tabs in list boxes, but GTK doesn't, so we
should make the tab stop in the forwarded-ports list explicit.

[originally from svn r2937]
2003-03-15 15:49:04 +00:00
Simon Tatham
03a7096b3c Missed a couple of the Unix-specific settings out of settings.c. One
of these days I'll have to separate the platform-specific settings
out into winsett and uxsett modules, but for now it's not too urgent.

[originally from svn r2936]
2003-03-15 09:42:15 +00:00
Simon Tatham
cbb126917f While I'm adding explanatory comments by the coroutine macros, it
occurs to me that would also be a good place to put a copy of the
instructions for disabling Edit and Continue debugging. Nobody
_actually_ reads the README, after all...

[originally from svn r2935]
2003-03-14 21:20:32 +00:00
Simon Tatham
de1562cade The divisor in the bell timing boxes should be TICKSPERSEC, not 1000.
[originally from svn r2934]
2003-03-14 21:18:13 +00:00
Simon Tatham
fca92a5b43 Continuing work on the GTK config box. Created uxcfg.c for the
Unix-specific config items; moved a stray Windows-specific config
item (scrollbar-in-fullscreen) out into wincfg.c to stop it
appearing on Unix; continued updates to gtkdlg.c. I now believe the
GTK config box looks basically correct (modulo minor cosmetic issues
and keyboard accelerators). Next step, add the event handling so
it's actually functional.

[originally from svn r2933]
2003-03-14 18:35:01 +00:00
Simon Tatham
df85003ea5 First stab at a GTK layout engine. It's missing all sorts of stuff
(list boxes are particularly conspicuously absent), it has no event
handling at all, and it isn't in any way integrated into pterm - you
have to build it specially using the test stubs in gtkdlg.c. But
what there is so far seems to work plausibly well, so it's a start.
Rather than browbeat the existing GTK container/layout widgets into
doing what I wanted, I decided to implement two subclasses of
GtkContainer myself, which implement precisely the layout model
assumed by the config box specification; this has the rather cool
consequence that the box can be resized and will maintain the same
layout at all times that it would have had if initially created at
that size.

[originally from svn r2931]
2003-03-13 19:52:28 +00:00
Ben Harris
a816d2df18 Increase PuTTY's default partition size to 2 MB. 1 MB just isn't enough.
[originally from svn r2928]
2003-03-11 22:35:07 +00:00
Simon Tatham
73203bce79 Never pass a `char' to a ctype function. I had relied on gcc -Wall
letting me know about instances of this, but it turns out that my
ctype.h explicitly casts input values to `int' to evade the
`subscript has type char' warning, so it had been carefully not
letting me know! Found them all by compiling with a doctored
ctype.h, and hopefully fixed them all too.

[originally from svn r2927]
2003-03-11 09:30:31 +00:00
Simon Tatham
43fe7d3c87 Add the ability to allocate extra per-dialog-instance private data
in the portable dialog interface. This has allowed me to remove
`ssd->savedsession' in config.c, which was (I believe) the only
out-of-place piece of per-instance data in the dialog template
stuff. Now we should actually be able to run more than one config
box in the same process at the same time (for platforms that'll find
that useful).

[originally from svn r2925]
2003-03-08 11:46:42 +00:00
Simon Tatham
e9cc328501 Richard B's patch for resize behaviour. The scrollback now contains
a marker which defines everything before it as `permanent'
scrollback and everything after it as `temporary'; only temporary
scrollback lines are returned to the main screen when the window
height is increased. Screen clears mark the lines pushed into the
scrollback as permanent; so lines explicitly cleared off the screen
by ESC[2J are never returned to it by mistake. This patch also fixes
the incorrect state the primary screen is left in when the window is
resized while the alternate screen is active.

[originally from svn r2923]
2003-03-07 18:18:38 +00:00
Simon Tatham
4efe692e88 Overnight docs build found a duplicate section keyword. Oops. Fixed.
[originally from svn r2921]
2003-03-07 09:03:11 +00:00
Ben Harris
43d2fa847f Alert box to support host-key checking.
[originally from svn r2920]
2003-03-06 23:46:06 +00:00
Ben Harris
33e7ee09ab Slightly better than null verify_ssh_host_key(). It's broken in more ways
than I can comfortably enumerate (see the comments in the code), but it's
better than always assuming everything's OK.

[originally from svn r2919]
2003-03-06 23:44:47 +00:00
Simon Tatham
c06c12983c Just for Jacob, the ciphers drag list is now six lines high instead
of five, so that the scroll bar doesn't show up when it's active.

[originally from svn r2918]
2003-03-06 19:20:33 +00:00
Simon Tatham
9e0a7aa86d Got a bit of a better handle on the whole GDI `logical units' mess,
and sorted out the static-control text wrapping rather better. Now
it works under both large fonts and small fonts on Win2K, so I have
high hopes that it's actually correct this time.

[originally from svn r2917]
2003-03-06 19:18:25 +00:00
Simon Tatham
88d0a45b0f Fix a couple of stupid typos in the session-saving code.
[originally from svn r2916]
2003-03-06 18:49:05 +00:00
Simon Tatham
3e311e94fc Jacob points out that TS_EOL is broken in BINARY mode.
[originally from svn r2915]
2003-03-06 13:25:48 +00:00
Simon Tatham
6f693ffeb0 Reorganisation of misc.c: Minefield has moved out to winmisc.c, and
so has the Windows dputs() - which has also acquired a Unix
counterpart in uxmisc.c. -DDEBUG should now work on Unix.

[originally from svn r2914]
2003-03-06 13:24:02 +00:00