1
0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-10 18:07:59 +00:00
Commit Graph

2408 Commits

Author SHA1 Message Date
Simon Tatham
c53056f95c Joe Yates's memory leak patch was overenthusiastically freeing
things; it called freebn on the DH gex values even if DH gex had not
taken place. Bug was trivially reproducible as a NULL-dereference
segfault by making any SSH2 connection with DH gex disabled. Should
now be fixed.

[originally from svn r3678]
2004-01-01 16:42:48 +00:00
Simon Tatham
cf0cfba9ca D'oh! WideFont and WideBoldFont were being read from session files,
but not written. I _thought_ something odd was happening with my
UTF-8 pterms.

[originally from svn r3673]
2003-12-31 16:09:55 +00:00
Simon Tatham
7a1eae7ff2 Joe Yates's memory leak patches.
[originally from svn r3650]
2003-12-19 12:44:46 +00:00
Simon Tatham
20bc740780 Andy Hood points out that `#ifdef MONITOR_DEFAULTTONEAREST' would
benefit from _also_ being conditional on NO_MULTIMON not being
defined, to prevent the possibility of only half the multimon code
being included.

[originally from svn r3644]
2003-12-16 18:28:43 +00:00
Jacob Nevins
79ffeb97fc tweak for consistency with previous checkin
[originally from svn r3622]
2003-12-04 00:10:07 +00:00
Jacob Nevins
5438acd044 Fix from Michael Wardle in bell error message
[originally from svn r3619]
2003-12-03 23:32:47 +00:00
Jacob Nevins
e9b9df0fb9 Spotted by Tim Kosse: reput on an already complete file was hanging.
Should be fixed now (we only wait for packets if we know there are some
that haven't been replied to yet).

[originally from svn r3618]
2003-12-03 23:25:48 +00:00
Jacob Nevins
40af5d16a3 Add updating the wishlist to the Release checklist
[originally from svn r3615]
2003-12-03 22:49:32 +00:00
Jacob Nevins
1c1c9d3ccf fflush(stdout) after each line of stats
[originally from svn r3614]
2003-12-03 22:45:32 +00:00
Jacob Nevins
d80be3891a Fix for `logging-save-default': allow logging settings to be saved with
Default Settings.

[originally from svn r3610]
2003-12-03 19:17:14 +00:00
Jacob Nevins
55402ab183 I think the time has come for PuTTYgen to mention "authorized_keys" instead
of "authorized_keys2" by default. I believe this change was made in OpenSSH
around June 2001, so any versions which it applies should have been replaced
by now for other reasons.
(The docs still adequately document the confusion surrounding this)

[originally from svn r3577]
2003-11-24 13:40:58 +00:00
Simon Tatham
f9f6763a0e Trivial braino in parsing of the port forwarding config data. Was
causing all port forwardings after the first dynamic one to be
ignored.

[originally from svn r3572]
2003-11-22 14:50:57 +00:00
Simon Tatham
c4f157a4e5 Introduce a new mouse handling option, in which the right button
brings up the context menu (and you can then paste by selecting
`Paste'). Should be more friendly to Windows-oriented users as
opposed to expatriate X users; also has the effect of making it more
difficult to paste into PuTTY by a single misplaced mouse click,
which has been a common theme of complaint recently.
For the moment, `Compromise' (the X-like behaviour with the right
and middle buttons reversed so that two-button users still get the
two most important functions) is still the default. I'm uncertain
that it might not be better to make the new option the default,
though, since the compromise option is optimal for _nobody_.

[originally from svn r3565]
2003-11-20 18:41:12 +00:00
Simon Tatham
5ff8c668e4 Move the `translation of line drawing characters when pasting'
option from the Selection panel to the Translation panel (where it
fits at least as well). This frees a line in the Selection panel
which I'm about to use for an additional mouse handling option.

[originally from svn r3564]
2003-11-20 18:33:22 +00:00
Simon Tatham
890582d297 Introduce a context menu which appears on Ctrl+rightclick. This menu
contains all the stuff in the System menu except for the standard
System menu bits (move, resize, close etc), and also contains `Paste'.

[originally from svn r3555]
2003-11-19 20:48:30 +00:00
Jacob Nevins
9f98f81271 Make that last checkin more explicit, and in particular reference the
"common errors" section of the documentation.

[originally from svn r3554]
2003-11-19 19:09:07 +00:00
Jacob Nevins
2778f4b825 Soften language in `faq-incorrect-mac': buggy ssh.com servers aren't the
only possible reason for this message.

[originally from svn r3553]
2003-11-19 19:03:24 +00:00
Simon Tatham
a06375ab96 I _think_ this should fix the problem reported by `Stacey': failure
to fclose a private key file.

[originally from svn r3552]
2003-11-19 17:30:16 +00:00
Jacob Nevins
a9e286ad57 Cosmetic fix from Daniel Fazekas: apparently we were failing to allow
window-furniture in Playschool Windows be animated on mouse-over. This
fix also seems like the Right Thing to do. I've tried it and it seems
harmless enough on Win2K.

[originally from svn r3536]
2003-11-06 14:17:56 +00:00
Simon Tatham
f4a4551d5b We now mention the version number on the Download page, so I'd
better remember to change it next time :-)

[originally from svn r3528]
2003-11-03 13:59:46 +00:00
Simon Tatham
d76a39d547 Close the host keys file after use. Well spotted Theo Markettos.
[originally from svn r3526]
2003-10-31 21:45:15 +00:00
Simon Tatham
69efc93547 Hmm, that relative link wasn't too good. Try a more helpful one.
Also add to the release checklist so that I'll remember to set this
up properly in the next set of release docs...

[originally from svn r3525]
2003-10-30 10:41:59 +00:00
Simon Tatham
f9abc2b092 Move the reference to sitestyle.css out into a separate .but file
which is only included if you explicitly tell the docs Makefile to
do so. Also make it a relative reference, while we're at it.

[originally from svn r3524]
2003-10-30 10:30:23 +00:00
Jacob Nevins
7bc5b64c20 Fix usage comments
[originally from svn r3519]
2003-10-21 13:26:12 +00:00
Jacob Nevins
82d093c549 Update faq-pscp-ascii.
[originally from svn r3509]
2003-10-15 12:09:24 +00:00
Jacob Nevins
a90f643907 Add `--unix' mode to generate ~/.putty/sshhostkeys from known_hosts.
(should now be called `kh2putty.py')

[originally from svn r3508]
2003-10-14 23:23:28 +00:00
Jacob Nevins
f2676b6ccc Remove dead comment about writing settings, and query one about reading them.
[originally from svn r3507]
2003-10-14 21:01:12 +00:00
Jacob Nevins
9860f1a10c We now have Unix ports of PSCP and PSFTP.
[originally from svn r3506]
2003-10-14 19:57:50 +00:00
Simon Tatham
4d76ca6658 Actually fix winnet-if2lo, I think. Tested in an ad-hoc manner by
deliberately making a connection from nemesis's real IP address to
its loopback address; not tested in the original failing case of SMB.

[originally from svn r3503]
2003-10-12 14:12:54 +00:00
Simon Tatham
e30aed9a6f The WinSock library is now loaded at run-time, which means we can
attempt to load WS2 and then fall back to WS1 if that fails. This
should allow us to use WS2-specific functionality to find out the
local system's list of IP addresses, thus fixing winnet-if2lo, while
degrading gracefully back to the previous behaviour if that
functionality is unavailable. (I haven't yet actually done this; I've
just laid the groundwork.)
This checkin _may_ cause instability; it seemed fine to me on
initial testing, but it's a bit of an upheaval and I wouldn't like
to make bets on it just yet.

[originally from svn r3502]
2003-10-12 13:46:12 +00:00
Jacob Nevins
8e2fd15bd5 Remove all the "assert(len>0)" which forbade zero-length writes across the
from_backend() interface, after having made all implementations safe against
being called with len==0 and possibly-NULL/undefined "data".

(This includes making misc.c:bufchain_add() more robust in this area.)

Assertion was originally added 2002-03-01; e.g., see plink.c:1.53 [r1571].

I believe this now shouldn't break anything.

This should hopefully make `ppk-empty-comment' finally GO AWAY. (Tested
with Unix PuTTY.)

[originally from svn r3500]
[r1571 == fdbd697801]
2003-10-12 13:16:39 +00:00
Jacob Nevins
5415873b3f Add random commentary to SOCKS code.
Also fix what I think are a couple of very minor bugs in SOCKS4; one won't
affect anyone AFAIK, and the other is unlikely to cause trouble.

[originally from svn r3497]
2003-10-10 22:58:53 +00:00
Jacob Nevins
4de860abcf In SOCKS5 dynamic forwarding, we were echoing back DST.{ADDR,PORT} as
BND.{ADDR,PORT}. Besides being clearly wrong, correspondence with
Sascha Schwarz suggests that this can confuse some SOCKS5 clients
(Aventail and sockscap32) which seem to assume that the reply must
have ATYP=1 (IPv4 literal) and so get the length wrong.

Now all replies have ATYP=1 with BND.{ADDR,PORT} = 0.0.0.0:0 -- this
apparently follows practice in OpenSSH. (We don't have enough info to
fill these fields in correctly.)

[originally from svn r3496]
2003-10-10 21:20:01 +00:00
Jacob Nevins
c8a6df1e1c missed a bit in last commit
[originally from svn r3490]
2003-10-08 21:39:54 +00:00
Owen Dunn
a03d04ba75 Cosmetic, to fix ssh2-des-cbc-is-std
[originally from svn r3488]
2003-10-08 20:09:55 +00:00
Jacob Nevins
c36ec63d28 `baltic-default-translation': change default Baltic (CP1257) encoding from
8859-4 to 8859-13 as suggested by Vaidrius Petrauskas, on the grounds that
he has a .lt address and sounds like he knows what he's talking about.

[originally from svn r3485]
2003-10-07 21:31:21 +00:00
Simon Tatham
72c53fcb75 My ASN.1 decoder returned wrong IDs for anything above 0x1E! Good
job it's never had to yet. Ahem.

[originally from svn r3479]
2003-10-03 21:21:23 +00:00
Simon Tatham
150b6e0a87 PSCP in SFTP mode now uses the fast download/upload manager.
[originally from svn r3472]
2003-09-29 15:39:56 +00:00
Simon Tatham
efa05f9752 Obvious memory leak in new fast download management. Oops.
[originally from svn r3471]
2003-09-29 15:39:36 +00:00
Simon Tatham
77cc301862 Uploads turn out to be much easier than downloads, so here's faster
upload support in PSFTP as well.

[originally from svn r3470]
2003-09-28 14:24:01 +00:00
Simon Tatham
bc83c59aa7 First cut at speeding up SFTP. Generic download-management code in
sftp.c, and psftp.c now uses that instead of going it alone. Should
in principle be easily installed in PSCP as well, but I haven't done
it yet; also it only handles downloads, not uploads, and finally it
doesn't yet properly calculate the correct number of parallel
requests to queue. Still, it's a start, and in my own tests it
seemed to perform as expected (download speed suddenly became
roughly what you'd expect from the available bandwidth, and
decreased by roughly the expected number of round-trip times).

[originally from svn r3468]
2003-09-27 17:52:34 +00:00
Jacob Nevins
e3018a08e8 Clarify what happens when you enter a code page that's not listed.
[originally from svn r3467]
2003-09-26 13:04:56 +00:00
Jacob Nevins
3250a5b0f0 Note what versions of SOCKS are implemented for dynamic port forwarding.
[originally from svn r3464]
2003-09-25 12:38:02 +00:00
Jacob Nevins
61ad562f72 Imply that some features that have been implemented may appear on the Wishlist
but not the Changes page, as this is now often the case.

[originally from svn r3459]
2003-09-23 10:12:02 +00:00
Jacob Nevins
701ad46226 Mention Windows on Alpha as worth mentioning
[originally from svn r3458]
2003-09-23 10:05:06 +00:00
Jacob Nevins
2cde290c77 Oops. Fix a bug in my `keyfile-diagnostic' work which caused SSH-2 key loading
in pageant (and presumably puttygen) to crash.

[originally from svn r3450]
2003-09-10 12:30:10 +00:00
Jacob Nevins
95d5a91c24 Implement `default-colours' on Windows based loosely on Michael Wardle's patch.
[originally from svn r3444]
2003-09-03 20:14:38 +00:00
Jacob Nevins
dbe68abfff Add pscp to .cvsignore
[originally from svn r3443]
2003-09-03 18:37:35 +00:00
Jacob Nevins
3796897d7c Change an incorrect comment about "PuTTY-User-Key-File-2" private key format
after discussion with Simon.

[originally from svn r3440]
2003-09-02 19:02:06 +00:00
Jacob Nevins
15ac9c09eb When loading SSH-2 key, ignore passphrase argument if key is unencrypted.
This should get rid of a problem that three or four people reported where
PuTTY intermittently reports "Unable to load private key" (MAC failed).

(ssh.c:do_ssh2_authconn() should also initialise its passphrase so it's not
passing garbage passphrases around, of course, but I haven't yet worked out
where the best place in the auth loop to do that would be.)

[originally from svn r3439]
2003-09-02 19:00:17 +00:00