mirror of
https://git.tartarus.org/simon/putty.git
synced 2025-01-10 01:48:00 +00:00
16d5bb7269
The protocol selector widgets were misaligned in GTK as well as on Windows, but for a completely different reason. (I guess both bugs must have been introduced at the same time when I reworked the system to tolerate more than two aligned widgets in commit b5ab90143a2df7f.) To vertically align N widgets, you have to first figure out what range of y-coordinates they jointly occupy, and then centre each one within that range. We were trying to do both jobs in the same pass, which meant trying to place the first widget before finding out where the last one will be. To do this, we were separately computing the y-range's start and width, the former by taking max of the y-coordinates _seen so far_, and the latter by taking max of _all_ the widgets' heights. This has two problems. One is that if you later find out that the y-coordinate of the top of the range needs to be lower than you'd previously realised, it's too late to go back and reposition the widgets you've already placed. But that's a theoretical issue that would only come up with more complicated column layouts than we've actually used. (And probably more complicated than would even be _sensible_ to use.) The other, more immediate, problem: the y-coordinates we were using for already-placed widgets in the set were the ones _after_ we adjusted each one for vertical centring. So if the first widget is short and the second taller (say, heights 20 and 30 pixels), then the first widget will be offset downwards by 5 pixels, but the second widget will use that offset y-coordinate as the _top_ of the range to fit itself into, and hence, will also be 5 pixels downward from where it should have been. I think only the second of those problems is immediately concerning, but it's easier to fix both at once. I've removed the y-adjustment for vertical centring from the main layout loop, and put it in a separate pass run after the main layout finishes. |
||
|---|---|---|
| .. | ||
| utils | ||
| agent-client.c | ||
| agent-socket.c | ||
| askpass.c | ||
| cliloop.c | ||
| CMakeLists.txt | ||
| columns.c | ||
| columns.h | ||
| config-gtk.c | ||
| config-unix.c | ||
| console.c | ||
| dialog.c | ||
| fd-socket.c | ||
| gss.c | ||
| gtk-common.c | ||
| gtkcompat.h | ||
| gtkmisc.h | ||
| keygen-noise.c | ||
| local-proxy.c | ||
| main-gtk-application.c | ||
| main-gtk-simple.c | ||
| network.c | ||
| no-gtk.c | ||
| noaskpass.c | ||
| noise.c | ||
| osxlaunch.c | ||
| pageant.c | ||
| peerinfo.c | ||
| platform.h | ||
| plink.c | ||
| printing.c | ||
| procnet.c | ||
| psocks.c | ||
| psusan.c | ||
| pterm-config-xpm.c | ||
| pterm-xpm.c | ||
| pterm.bundle | ||
| pterm.c | ||
| pterm.plist | ||
| pty.c | ||
| putty-config-xpm.c | ||
| putty-xpm.c | ||
| putty.bundle | ||
| putty.c | ||
| putty.plist | ||
| serial.c | ||
| sftp.c | ||
| sftpserver.c | ||
| sharing.c | ||
| storage.c | ||
| unicode.c | ||
| unifont.c | ||
| unifont.h | ||
| uppity.c | ||
| uxsel.c | ||
| window.c | ||
| x11.c | ||
| x11misc.h | ||