mirror of
https://git.tartarus.org/simon/putty.git
synced 2025-05-29 07:44:48 -05:00
27f0140e5c
Spotted by Coverity. If PuTTY is functioning as a sharing upstream, and a new downstream mishandles the version string exchange in any way that provokes an error message from share_receive() (such as failing to start the greeting with the expected protocol-name string), we were calling share_disconnect() and then going to crFinish. But share_disconnect is capable of actually freeing the entire ssh_sharing_connstate which contains the coroutine state - in which case, crFinish's zeroing out of crLine is a use-after-free. The usual pattern elsewhere in this code is to exit a coroutine with an ordinary 'return' when you've destroyed its state structure. Switch to doing that here.
This is the README for PuTTY, a free Windows and Unix Telnet and SSH
client.
PuTTY is built using CMake <https://cmake.org/>. To compile in the
simplest way (on any of Linux, Windows or Mac), run these commands in
the source directory:
cmake .
cmake --build .
Then, to install in the simplest way on Linux or Mac:
cmake --build . --target install
On Unix, pterm would like to be setuid or setgid, as appropriate, to
permit it to write records of user logins to /var/run/utmp and
/var/log/wtmp. (Of course it will not use this privilege for
anything else, and in particular it will drop all privileges before
starting up complex subsystems like GTK.) The cmake install step
doesn't attempt to add these privileges, so if you want user login
recording to work, you should manually ch{own,grp} and chmod the
pterm binary yourself after installation. If you don't do this,
pterm will still work, but not update the user login databases.
Documentation (in various formats including Windows Help and Unix
`man' pages) is built from the Halibut (`.but') files in the `doc'
subdirectory. If you aren't using one of our source snapshots,
you'll need to do this yourself. Halibut can be found at
<https://www.chiark.greenend.org.uk/~sgtatham/halibut/>.
The PuTTY home web site is
https://www.chiark.greenend.org.uk/~sgtatham/putty/
If you want to send bug reports or feature requests, please read the
Feedback section of the web site before doing so. Sending one-line
reports saying `it doesn't work' will waste your time as much as
ours.
See the file LICENCE for the licence conditions.