mirror of
https://git.tartarus.org/simon/putty.git
synced 2025-01-09 17:38:00 +00:00
5f2eff2fea
This was requested by a downstream of the code, who wanted to change the time/space tradeoff in the terminal. I currently have no plans to change this setting for upstream PuTTY, although there is a cmake option for it just to make testing it easy. To avoid sprinkling ifdefs over the whole terminal code, the strategy is to keep the separate type 'compressed_scrollback_line', and turn it into a typedef for a 'termline *'. So compressline() becomes almost trivial, and decompressline() even more so. Memory management is the fiddly part. To make this work sensibly on both sides, I've broken up each of compressline() and decompressline() into two versions, one of which takes ownership of (and logically speaking frees) its input, and the other doesn't. So at call sites where a function was followed by a free, it's now calling the 'and_free' version of the function, and where the input object was reused afterwards, it's calling the 'no_free' version. This means that in different branches of the #if, I can make one function call the other or vice versa, and no call site is stuck with having to do things in a more roundabout way than necessary. The freeing of the _return_ value from decompressline() is handled for us, because termlines already have a 'temporary' flag which is set when they're returned from the decompressor, and anyone receiving a termline from lineptr() calls unlineptr() when they're finished with it, which will _conditionally_ free it, depending on that 'temporary' flag. So in the new mode, 'temporary' is never set at all, and all those unlineptr() calls do nothing. However, we also still need to free compressed lines properly when they're actually being thrown away (scrolled off the top of the scrollback, or cleaned up in term_free), and for that, I've made a new special-purpose free_compressed_line() function. |
||
|---|---|---|
| .. | ||
| bidi_gettype.c | ||
| bidi_test.c | ||
| bidi.c | ||
| bidi.h | ||
| terminal.c | ||
| terminal.h | ||