1
0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-10 01:48:00 +00:00
putty-source/windows
Jacob Nevins 651cedc7fb On Windows, MessageBoxIndirect() was sometimes failing to pop up the host key
dialog and returning an unexpected value (0), causing everything to silently
behave as if the user had said "allow this connection but don't store host
key"!

Initialising (MSGBOXPARAMS).hInstance seems to have cured this (although the
MSDN docs seemed to indicate it wouldn't be used) -- if so, it's been broken
since r5309 on 2004-02-15 -- but since this was something of a Heisenbug, and
the behaviour was so catastrophic when MessageBoxIndirect() behaved oddly, I've
rearranged the code to default to cancelling, and added an assertion for
visibility.

(Windows PuTTY still seems to be broken wrt servers that send NEWKEYS while
we're waiting for the user, which happens to include the "SSH-2.0-2.4.1 SSH
Secure Shell OpenVMS V1.0" I'm testing against. I don't know why. The above bug
may also have been limited to this circumstance.)

[originally from svn r5370]
[r5309 == 99122767f5]
2005-02-20 23:00:17 +00:00
..
pageant.ico Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
pageant.mft Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
pageant.rc It's a new year! 2005-01-02 09:19:14 +00:00
pageants.ico Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
plink.rc Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
pscp.ico Rename scp.* to pscp.*, because I always misspell it that way. Also 2004-12-16 15:01:43 +00:00
pscp.rc Rename scp.* to pscp.*, because I always misspell it that way. Also 2004-12-16 15:01:43 +00:00
putty.ico Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
putty.iss Bump version numbers. (Forgot to do this _before_ dropping the 0.57 2005-02-20 10:51:02 +00:00
putty.mft Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
puttycfg.ico Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
puttygen.ico Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
puttygen.mft Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
puttygen.rc It's a new year! 2005-01-02 09:19:14 +00:00
sizetip.c Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
website.url Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
win_res.h Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
win_res.rc It's a new year! 2005-01-02 09:19:14 +00:00
wincfg.c Briefly document the "CP866" manual-entry feature on Windows in the dialog 2004-11-29 09:23:11 +00:00
wincons.c Add asynchronous callback capability to the askappend() alert box. 2005-02-18 18:33:31 +00:00
winctrls.c Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
windefs.c Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
windlg.c On Windows, MessageBoxIndirect() was sometimes failing to pop up the host key 2005-02-20 23:00:17 +00:00
window.c Minor reorganisations to WinHelp support. (Done as part of a - failed - 2005-02-16 01:47:10 +00:00
winhelp.h The Windows host key dialogs now have a `Help' button that should give 2005-02-15 22:23:47 +00:00
winmisc.c Integrate unfix.org's IPv6 patches up to level 10, with rather a lot 2004-12-30 16:45:11 +00:00
winnet.c Martin Prikryl points out that we weren't always initialising new "addrinfo" 2005-02-14 11:43:27 +00:00
winnoise.c Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
winpgen.c Minor reorganisations to WinHelp support. (Done as part of a - failed - 2005-02-16 01:47:10 +00:00
winpgnt.c Minor reorganisations to WinHelp support. (Done as part of a - failed - 2005-02-16 01:47:10 +00:00
winpgntc.c Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
winplink.c A couple of people have pointed out that the local variable 2004-12-31 19:06:20 +00:00
winprint.c Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
winsftp.c General mechanism for ensuring a dodgy SFTP server can't return 2004-12-16 19:36:47 +00:00
winstore.c Fix potential access of freed data (only if we couldn't create the 2004-12-22 23:17:02 +00:00
winstuff.h Minor reorganisations to WinHelp support. (Done as part of a - failed - 2005-02-16 01:47:10 +00:00
wintime.c New function ltime() returns a struct tm of the current local time. 2005-01-09 14:27:48 +00:00
winucs.c Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00
winutils.c Now that we have Subversion's file renaming ability, it's time at 2004-11-16 22:14:56 +00:00