Simon Tatham
721650bcb1
Fix dodgy strcats in access_random_seed().
...
Looking over this function today, I spotted several questionable uses
of strcat to concatenate "\PUTTY.RND" to the end of a pathname,
without having checked whether the pathname had filled up the static
fixed-size buffer already.
I don't think this is exploitable (because you'd have to be in control
of the local account already to control any of the data sources used
to fill those buffers). But it's horrible anyway, of course. Now all
of those are replaced with sensible dupcats.
(This patch re-indents a lot of the function, to give variables
tighter scopes. So the diff is best viewed with whitespace ignored.)
2019-07-10 20:47:09 +01:00
..
2019-03-16 12:25:23 +00:00
2018-08-21 07:17:06 +01:00
2007-01-07 10:17:12 +00:00
2015-08-15 13:54:44 +01:00
2019-03-18 20:32:55 +00:00
2007-01-07 10:17:12 +00:00
2005-10-04 14:13:28 +00:00
2007-01-07 10:17:12 +00:00
2005-10-04 14:13:28 +00:00
2005-10-04 14:13:28 +00:00
2007-01-07 10:17:12 +00:00
2015-08-15 13:54:44 +01:00
2019-03-16 12:25:23 +00:00
2007-01-07 10:17:12 +00:00
2007-01-07 10:17:12 +00:00
2015-08-15 13:54:44 +01:00
2019-03-18 20:32:55 +00:00
2007-02-06 22:39:15 +00:00
2018-10-06 11:57:59 +01:00
2019-03-16 12:25:23 +00:00
2017-09-13 19:26:28 +01:00
2019-03-18 21:53:45 +00:00
2018-11-03 13:45:00 +00:00
2019-03-18 22:02:13 +00:00
2017-05-07 16:29:01 +01:00
2019-03-16 12:25:23 +00:00
2019-03-18 20:32:55 +00:00
2018-11-03 13:45:00 +00:00
2018-11-03 13:45:00 +00:00
2018-11-03 13:45:00 +00:00
2019-03-16 12:25:23 +00:00
2019-06-30 15:02:30 +01:00
2018-11-03 13:45:00 +00:00
2019-03-09 16:21:49 +00:00
2019-06-18 06:58:51 +01:00
2019-03-19 23:55:26 +00:00
2019-02-28 20:15:38 +00:00
2019-03-26 00:27:04 +00:00
2019-03-26 00:27:04 +00:00
2019-03-16 12:25:23 +00:00
2019-04-20 08:29:23 +01:00
2018-11-03 13:45:00 +00:00
2019-03-16 12:25:23 +00:00
2019-02-20 07:27:13 +00:00
2019-06-19 06:49:24 +01:00
2019-03-16 12:25:23 +00:00
2019-05-05 20:28:00 +01:00
2010-12-27 00:24:48 +00:00
2018-11-03 13:47:29 +00:00
2018-11-03 13:47:29 +00:00
2019-04-19 15:48:53 +01:00
2019-02-04 20:32:31 +00:00
2019-02-04 20:32:31 +00:00
2019-06-18 06:58:51 +01:00
2019-02-06 21:46:10 +00:00
2018-11-03 13:47:29 +00:00
2018-11-03 13:45:00 +00:00
2018-11-03 13:45:00 +00:00
2019-03-16 12:25:23 +00:00
2019-03-09 16:21:49 +00:00
2019-01-20 17:09:24 +00:00
2019-07-10 20:47:09 +01:00
2019-03-16 12:25:23 +00:00
2017-02-14 23:25:25 +00:00
2019-07-02 21:22:01 +01:00
2019-03-21 12:57:09 +00:00
2018-11-03 13:45:00 +00:00