Simon Tatham c2d7ea8e67 Fix use of aligned_alloc() to be ASan-clean. ...

aligned_alloc() is used by testsc for all its memory allocation, to
avoid false-positive timing variations that depend on memory alignment
rather than actual secret data. But I'd forgotten that aligned_alloc
requires the allocation size to be a multiple of the requested
alignment.

This showed up when I ran testsc in dry-run mode, and my normal build
happened to be using ASan, which complains at the invalid allocation
size. But it was theoretically a problem in all builds of
testsc. (Though, as far as I'm aware, not practically; and it _only_
affected testsc.)

2024-12-07 22:36:11 +00:00

..

antispoof.c

…

backend_socket_log.c

…

base64_decode_atom.c

…

base64_decode.c

…

base64_encode_atom.c

…

base64_encode.c

…

base64_valid.c

…

bufchain.c

…

buildinfo.c

…

burnstr.c

…

burnwcs.c

…

cert-expr.c

…

chomp.c

…

CMakeLists.txt

…

cmdline_get_passwd_input_state_new.c

…

conf_data.c

…

conf_debug.c

…

conf_dest.c

…

conf_launchable.c

…

conf.c

…

ctrlparse.c

…

ctrlset_normalise.c

…

debug.c

…

decode_utf8_to_wchar.c

…

decode_utf8_to_wide_string.c

…

decode_utf8.c

…

default_description.c

…

dup_mb_to_wc.c

…

dup_wc_to_mb.c

…

dupcat.c

…

dupprintf.c

…

dupstr.c

…

dupwcs.c

…

encode_utf8.c

…

encode_wide_string_as_utf8.c

…

fgetline.c

…

host_ca_new_free.c

…

host_strchr_internal.c

…

host_strchr.c

…

host_strcspn.c

…

host_strduptrim.c

…

host_strrchr.c

…

key_components.c

…

log_proxy_stderr.c

…

logeventf.c

…

ltime.c

…

make_spr_sw_abort_static.c

…

marshal.c

…

memory.c

…

memxor.c

…

nullstrcmp.c

…

out_of_memory.c

…

parse_blocksize.c

…

percent_decode.c

…

percent_encode.c

…

prompts.c

…

ptrlen.c

…

read_file_into.c

…

seat_connection_fatal.c

…

seat_dialog_text.c

…

seat_nonfatal.c

…

sessprep.c

…

sk_free_peer_info.c

…

smemclr.c

…

smemeq.c

…

spr_get_error_message.c

…

ssh2_pick_fingerprint.c

…

ssh_key_clone.c

…

sshutils.c

…

strbuf.c

…

string_length_for_printf.c

…

stripctrl.c

…

tempseat.c

…

tree234.c

…

unicode-known.c

…

unicode-norm.c

…

utils.h

…

validate_manual_hostkey.c

…

version.c

…

wcwidth.c

…

wildcard.c

…

wordwrap.c

…

write_c_string_literal.c

…

x11_dehexify.c

…

x11_identify_auth_proto.c

…

x11_make_greeting.c

…

x11_parse_ip.c

…

x11authfile.c

…

x11authnames.c

…