1
0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-09 17:38:00 +00:00
putty-source/unix
Simon Tatham 1dc5659aa6 New option to reject 'trivial' success of userauth.
Suggested by Manfred Kaiser, who also wrote most of this patch
(although outlying parts, like documentation and SSH-1 support, are by
me).

This is a second line of defence against the kind of spoofing attacks
in which a malicious or compromised SSH server rushes the client
through the userauth phase of SSH without actually requiring any auth
inputs (passwords or signatures or whatever), and then at the start of
the connection phase it presents something like a spoof prompt,
intended to be taken for part of userauth by the user but in fact with
some more sinister purpose.

Our existing line of defence against this is the trust sigil system,
and as far as I know, that's still working. This option allows a bit of
extra defence in depth: if you don't expect your SSH server to
trivially accept authentication in the first place, then enabling this
option will cause PuTTY to disconnect if it unexpectedly does so,
without the user having to spot the presence or absence of a fiddly
little sigil anywhere.

Several types of authentication count as 'trivial'. The obvious one is
the SSH-2 "none" method, which clients always try first so that the
failure message will tell them what else they can try, and which a
server can instead accept in order to authenticate you unconditionally.
But there are two other ways to do it that we know of: one is to run
keyboard-interactive authentication and send an empty INFO_REQUEST
packet containing no actual prompts for the user, and another even
weirder one is to send USERAUTH_SUCCESS in response to the user's
preliminary *offer* of a public key (instead of sending the usual PK_OK
to request an actual signature from the key).

This new option detects all of those, by clearing the 'is_trivial_auth'
flag only when we send some kind of substantive authentication response
(be it a password, a k-i prompt response, a signature, or a GSSAPI
token). So even if there's a further path through the userauth maze we
haven't spotted, that somehow avoids sending anything substantive, this
strategy should still pick it up.

(cherry picked from commit 5f5c710cf3)
2021-06-23 21:01:50 +01:00
..
configure Move the Unix configure script up to the top level. 2014-02-22 18:01:32 +00:00
gtkapp.c Move all extern declarations into header files. 2018-11-03 13:47:29 +00:00
gtkask.c Unix pageant: handle askpass dialog close button. 2021-04-05 18:00:16 +01:00
gtkcfg.c Whitespace rationalisation of entire code base. 2019-09-08 20:29:21 +01:00
gtkcols.c Whitespace rationalisation of entire code base. 2019-09-08 20:29:21 +01:00
gtkcols.h Whitespace rationalisation of entire code base. 2019-09-08 20:29:21 +01:00
gtkcomm.c Whitespace rationalisation of entire code base. 2019-09-08 20:29:21 +01:00
gtkcompat.h gtkcompat.h: fix GTK1 implementation of ref_sink. 2019-11-02 08:26:14 +00:00
gtkdlg.c dialog system: add a side-by-side alignment feature. 2021-04-10 09:43:25 +01:00
gtkfont.c unifontsel: add extra double-checks of fontinfo values. 2021-04-10 08:57:24 +01:00
gtkfont.h Support SGR 9 for strikethrough effect on text. 2020-08-13 21:08:53 +01:00
gtkmain.c GTK: fix control flow in do_cmdline(). 2020-06-21 16:39:47 +01:00
gtkmisc.c Convert a lot of 'int' variables to 'bool'. 2018-11-03 13:45:00 +00:00
gtkmisc.h Convert a lot of 'int' variables to 'bool'. 2018-11-03 13:45:00 +00:00
gtkwin.c Make TermWin's palette_get_overrides() take a Terminal *. 2021-06-12 14:08:10 +01:00
osxlaunch.c osxlaunch: stop setting DYLD_LIBRARY_PATH. 2017-12-20 10:04:02 +00:00
procnet.c Add a /proc/net magic authenticator. 2019-03-31 10:35:10 +01:00
pterm.bundle OS X makefile: stop depending on JHBUILD_PREFIX. 2017-11-26 11:45:48 +00:00
pterm.plist Whitespace rationalisation of entire code base. 2019-09-08 20:29:21 +01:00
putty.bundle OS X makefile: stop depending on JHBUILD_PREFIX. 2017-11-26 11:45:48 +00:00
putty.plist Whitespace rationalisation of entire code base. 2019-09-08 20:29:21 +01:00
unix.h Pass more information to interactive host key check. 2021-03-13 13:54:59 +00:00
ux_x11.c Make dupcat() into a variadic macro. 2019-10-14 19:42:37 +01:00
uxagentc.c Merge the two low-level portfwd setup systems. 2020-01-27 19:40:50 +00:00
uxagentsock.c Fix a few 'triple letter in place of double' typos. 2021-01-17 09:18:42 +00:00
uxcfg.c Rework per-backend GUI configuration. 2020-03-10 21:27:57 +00:00
uxcliloop.c Factor out common code from Unix CLI main loops. 2020-02-07 19:14:32 +00:00
uxcons.c Console host key prompts: add 'more info' action. 2021-03-13 13:54:59 +00:00
uxfdsock.c Fix typo in a top-of-file comment. 2020-03-10 21:11:14 +00:00
uxgen.c Whitespace rationalisation of entire code base. 2019-09-08 20:29:21 +01:00
uxgss.c Whitespace rationalisation of entire code base. 2019-09-08 20:29:21 +01:00
uxmisc.c Whitespace rationalisation of entire code base. 2019-09-08 20:29:21 +01:00
uxnet.c Change vtable defs to use C99 designated initialisers. 2020-03-10 21:06:29 +00:00
uxnogtk.c Include the compile-time GTK version in the build info. 2017-02-15 19:32:42 +00:00
uxnoise.c Whitespace rationalisation of entire code base. 2019-09-08 20:29:21 +01:00
uxpeer.c Convert a lot of 'int' variables to 'bool'. 2018-11-03 13:45:00 +00:00
uxpgnt.c uxpgnt: Briefly document --symlink and --test-sign. 2021-04-19 15:40:35 +01:00
uxplink.c New option to reject 'trivial' success of userauth. 2021-06-23 21:01:50 +01:00
uxpoll.c pollwrap: stop returning unasked-for rwx statuses. 2020-06-14 15:49:36 +01:00
uxprint.c Whitespace rationalisation of entire code base. 2019-09-08 20:29:21 +01:00
uxproxy.c Make the plug_log type code into an enum. 2020-02-07 19:17:45 +00:00
uxpsusan.c psusan: write a man page. 2020-12-13 12:36:38 +00:00
uxpterm.c Move all window-title management into Terminal. 2021-02-07 19:59:20 +00:00
uxpty.c Merge the 0.74 release branch back to master. 2020-06-27 08:11:22 +01:00
uxputty.c Move all window-title management into Terminal. 2021-02-07 19:59:20 +00:00
uxsel.c Whitespace rationalisation of entire code base. 2019-09-08 20:29:21 +01:00
uxser.c Fix a few memory leaks spotted by Coverity. 2021-04-10 08:59:27 +01:00
uxserver.c Uppity: add stunt for unauthorised agent forwarding attempts. 2020-12-23 22:26:44 +00:00
uxsftp.c Fix assorted minor memory leaks. 2020-06-21 16:39:47 +01:00
uxsftpserver.c psusan: fix assertion failure in SFTP server. 2020-11-04 21:50:47 +00:00
uxshare.c Make dupcat() into a variadic macro. 2019-10-14 19:42:37 +01:00
uxsignal.c Whitespace rationalisation of entire code base. 2019-09-08 20:29:21 +01:00
uxsocks.c Auxiliary application: 'psocks', a simple SOCKS server. 2020-02-23 16:36:27 +00:00
uxstore.c New functions to shrink a strbuf. 2020-02-09 08:51:37 +00:00
uxucs.c uxucs.c: fix type of wcrtomb return value. 2020-06-14 15:49:36 +01:00
uxutils.c Hardware-accelerated SHA-512 on the Arm architecture. 2020-12-24 15:39:54 +00:00
uxutils.h Include <sys/sysctl.h> for Intel builds 2020-12-25 06:57:35 +00:00
x11misc.c Add lots of missing 'static' keywords. 2020-01-29 06:44:18 +00:00
x11misc.h Basic support for running under GDK Wayland back end. 2018-05-09 09:21:27 +01:00
xkeysym.c Whitespace rationalisation of entire code base. 2019-09-08 20:29:21 +01:00
xpmptcfg.c Tweak the icon script, and the generated icons, to more closely 2007-01-07 10:17:12 +00:00
xpmpterm.c Tweak the icon script, and the generated icons, to more closely 2007-01-07 10:17:12 +00:00
xpmpucfg.c Tweak the icon script, and the generated icons, to more closely 2007-01-07 10:17:12 +00:00
xpmputty.c Tweak the icon script, and the generated icons, to more closely 2007-01-07 10:17:12 +00:00