mirror of
https://git.tartarus.org/simon/putty.git
synced 2025-07-12 16:47:42 -05:00
c6ff548ae0
I found recently that if I ran Windows PSCP as a connection-sharing downstream, it would send the SSH greeting down the named pipe, but never receive anything back, though the upstream PuTTY was sending it. PuTTY and Plink from the same build of the code would act happily as downstreams. It turned out that this was because the WaitForMultipleObjects call in cli_main_loop() in wincliloop.c was failing with ERROR_ACCESS_DENIED. That happened because it had an INVALID_HANDLE_VALUE in its list of objects to wait for. That in turn happened because winselcli_event was set to INVALID_HANDLE_VALUE. Why was winselcli_event not set up? Because it's set up lazily by do_select(), so if the program isn't handling any network sockets at all (which is the case when PSCP is speaking over a named pipe instead), then it never gets made into a valid event object. So the problem wasn't that winselcli_event was in a bad state; it was quite legitimately invalid. The problem was that wincliloop ought to have _coped_ with it being invalid, by not inserting it in its list of objects to wait for. So now we check that case, and only insert winselcli_event in the list if it's valid. And PSCP works again over connection sharing.