1
0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-10 01:48:00 +00:00
putty-source/ssh
Simon Tatham d42f1fe96d Remove 'calling_back' parameter from plug_closing.
It was totally unused. No implementation of the 'closing' method in a
Plug vtable was checking it for any reason at all, except for
ProxySocket which captured it from its client in order to pass on to
its server (which, perhaps after further iterations of ProxySocket,
would have ended up ignoring it similarly). And every caller of
plug_closing set it to 0 (aka false), except for the one in sshproxy.c
which passed true (but it would have made no difference to anyone).

The comment in network.h refers to a FIXME comment which was in
try_send() when that code was written (see winnet.c in commit
7b0e082700). That FIXME is long gone, replaced by a use of a
toplevel callback. So I think the aim must have been to avoid
re-entrancy when sk_write called try_send which encountered a socket
error and called back to plug_closing - but that's long since fixed by
other means now.
2021-10-24 09:58:59 +01:00
..
agentf.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
bpp1.c New Seat callback, seat_sent(). 2021-06-27 13:52:48 +01:00
bpp2.c New Seat callback, seat_sent(). 2021-06-27 13:52:48 +01:00
bpp-bare.c New Seat callback, seat_sent(). 2021-06-27 13:52:48 +01:00
bpp.h Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
censor1.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
censor2.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
channel.h Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
CMakeLists.txt Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
common.c Localise user_input to SSH connection layers. 2021-09-14 14:05:13 +01:00
connection1-client.c Divide seat_set_trust_status into query and update. 2021-09-12 09:52:46 +01:00
connection1-server.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
connection1.c Localise user_input to SSH connection layers. 2021-09-14 14:05:13 +01:00
connection1.h Localise user_input to SSH connection layers. 2021-09-14 14:05:13 +01:00
connection2-client.c Divide seat_set_trust_status into query and update. 2021-09-12 09:52:46 +01:00
connection2-server.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
connection2.c Localise user_input to SSH connection layers. 2021-09-14 14:05:13 +01:00
connection2.h Localise user_input to SSH connection layers. 2021-09-14 14:05:13 +01:00
crc-attack-detector.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
gss.h Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
gssc.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
gssc.h Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
kex2-client.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
kex2-server.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
login1-server.c Localise user_input to SSH connection layers. 2021-09-14 14:05:13 +01:00
login1.c Localise user_input to SSH connection layers. 2021-09-14 14:05:13 +01:00
mainchan.c Localise user_input to SSH connection layers. 2021-09-14 14:05:13 +01:00
nogss.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
nosharing.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
pgssapi.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
pgssapi.h Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
portfwd.c Remove 'calling_back' parameter from plug_closing. 2021-10-24 09:58:59 +01:00
ppl.h Localise user_input to SSH connection layers. 2021-09-14 14:05:13 +01:00
scpserver.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
server.c Remove 'calling_back' parameter from plug_closing. 2021-10-24 09:58:59 +01:00
server.h Uppity: add command-line options to configure auth methods. 2021-09-28 18:09:36 +01:00
sesschan.c Remove 'calling_back' parameter from plug_closing. 2021-10-24 09:58:59 +01:00
sftp.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
sftp.h Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
sftpcommon.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
sftpserver.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
sharing.c Remove 'calling_back' parameter from plug_closing. 2021-10-24 09:58:59 +01:00
signal-list.h Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
ssh.c Remove 'calling_back' parameter from plug_closing. 2021-10-24 09:58:59 +01:00
transient-hostkey-cache.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
transport2.c Localise user_input to SSH connection layers. 2021-09-14 14:05:13 +01:00
transport2.h Spelling: standardise on "DSA", not "DSS". 2021-04-22 18:34:47 +01:00
ttymode-list.h Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00
userauth2-client.c Promote ssh2_userauth_antispoof_msg into utils. 2021-09-16 17:49:31 +01:00
userauth2-server.c Uppity: add stunt options for trivial authentication. 2021-06-19 21:34:56 +01:00
verstring.c Bug workaround to delay sending our SSH greeting. 2021-08-14 11:46:21 +01:00
x11fwd.c Remove 'calling_back' parameter from plug_closing. 2021-10-24 09:58:59 +01:00
zlib.c Move the SSH implementation into its own subdirectory. 2021-04-22 18:09:13 +01:00