mirror of
https://git.tartarus.org/simon/putty.git
synced 2025-01-10 01:48:00 +00:00
de38a4d826
This is a pure refactoring: no functional change expected. This commit introduces two new small vtable-style APIs. One is PageantClient, which identifies a particular client of the Pageant 'core' (meaning the code that handles each individual request). This changes pageant_handle_msg into an asynchronous operation: you pass in an agent request message and an identifier, and at some later point, the got_response method in your PageantClient will be called with the answer (and the same identifier, to allow you to match requests to responses). The trait vtable also contains a logging system. The main importance of PageantClient, and the reason why it has to exist instead of just passing pageant_handle_msg a bare callback function pointer and context parameter, is that it provides robustness if a client stops existing while a request is still pending. You call pageant_unregister_client, and any unfinished requests associated with that client in the Pageant core will be cleaned up, so that you're guaranteed that after the unregister operation, no stray callbacks will happen with a stale pointer to that client. The WM_COPYDATA interface of Windows Pageant is a direct client of this API. The other client is PageantListener, the system that lives in pageant.c and handles stream-based agent connections for both Unix Pageant and the new Windows named-pipe IPC. More specifically, each individual connection to the listening socket is a separate PageantClient, which means that if a socket is closed abruptly or suffers an OS error, that client can be unregistered and any pending requests cancelled without disrupting other connections. Users of PageantListener have a second client vtable they can use, called PageantListenerClient. That contains _only_ logging facilities, and at the moment, only Unix Pageant bothers to use it (and even that only in debugging mode). Finally, internally to the Pageant core, there's a new trait called PageantAsyncOp which describes an agent request in the process of being handled. But at the moment, it has only one trivial implementation, which is handed the full response message already constructed, and on the next toplevel callback, passes it back to the PageantClient. |
||
---|---|---|
.. | ||
installer.wxs | ||
msiplatform.py | ||
pageant.ico | ||
pageant.mft | ||
pageant.rc | ||
pageants.ico | ||
plink.rc | ||
pscp.ico | ||
pscp.rc | ||
psftp.rc | ||
putty.ico | ||
putty.mft | ||
putty.rc | ||
puttycfg.ico | ||
puttygen.ico | ||
puttygen.mft | ||
puttygen.rc | ||
puttyins.ico | ||
puttytel.mft | ||
puttytel.rc | ||
rcstuff.h | ||
README-msi.txt | ||
sizetip.c | ||
version.rc2 | ||
website.url | ||
win_res.h | ||
win_res.rc2 | ||
wincapi.c | ||
wincapi.h | ||
wincfg.c | ||
wincons.c | ||
winctrls.c | ||
windefs.c | ||
windlg.c | ||
window.c | ||
wingss.c | ||
winhandl.c | ||
winhelp.c | ||
winhelp.h | ||
winhelp.rc2 | ||
winhsock.c | ||
winjump.c | ||
winmisc.c | ||
winmiscs.c | ||
winnet.c | ||
winnohlp.c | ||
winnoise.c | ||
winnojmp.c | ||
winnpc.c | ||
winnps.c | ||
winpgen.c | ||
winpgnt.c | ||
winpgntc.c | ||
winplink.c | ||
winprint.c | ||
winproxy.c | ||
winsecur.c | ||
winsecur.h | ||
winselcli.c | ||
winselgui.c | ||
winser.c | ||
winsftp.c | ||
winshare.c | ||
winstore.c | ||
winstuff.h | ||
wintime.c | ||
winucs.c | ||
winutils.c | ||
winx11.c |