nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-04-06 21:48:12 -05:00
Code

Remove Secrets Manager LaunchDarkly feature flag (#2925)

Browse Source
This commit is contained in:
Matt Bishop 2023-05-11 10:27:58 -04:00 committed by GitHub
parent 620a7e0a8d
commit 99b0953acd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Core/Constants.cs
View File

@ -27,7 +27,6 @@ public static class AuthenticationSchemes
public static class FeatureFlagKeys public static class FeatureFlagKeys
{ {
public const string SecretsManager = "secrets-manager";
public const string DisplayEuEnvironment = "display-eu-environment"; public const string DisplayEuEnvironment = "display-eu-environment";
public const string DisplayLowKdfIterationWarning = "display-kdf-iteration-warning"; public const string DisplayLowKdfIterationWarning = "display-kdf-iteration-warning";
public const string TrustedDeviceEncryption = "trusted-device-encryption"; public const string TrustedDeviceEncryption = "trusted-device-encryption";

8
test/Core.Test/Services/LaunchDarklyFeatureServiceTests.cs
View File

@ -47,7 +47,7 @@ public class LaunchDarklyFeatureServiceTests
var currentContext = Substitute.For<ICurrentContext>(); var currentContext = Substitute.For<ICurrentContext>();
currentContext.UserId.Returns(Guid.NewGuid()); currentContext.UserId.Returns(Guid.NewGuid());
Assert.False(sutProvider.Sut.IsEnabled(FeatureFlagKeys.SecretsManager, currentContext)); Assert.False(sutProvider.Sut.IsEnabled("somekey", currentContext));
} }
[Fact(Skip = "For local development")] [Fact(Skip = "For local development")]
@ -61,7 +61,7 @@ public class LaunchDarklyFeatureServiceTests
var currentContext = Substitute.For<ICurrentContext>(); var currentContext = Substitute.For<ICurrentContext>();
currentContext.UserId.Returns(Guid.NewGuid()); currentContext.UserId.Returns(Guid.NewGuid());
Assert.False(sutProvider.Sut.IsEnabled(FeatureFlagKeys.SecretsManager, currentContext)); Assert.False(sutProvider.Sut.IsEnabled("somekey", currentContext));
} }
[Fact(Skip = "For local development")] [Fact(Skip = "For local development")]
@ -75,7 +75,7 @@ public class LaunchDarklyFeatureServiceTests
var currentContext = Substitute.For<ICurrentContext>(); var currentContext = Substitute.For<ICurrentContext>();
currentContext.UserId.Returns(Guid.NewGuid()); currentContext.UserId.Returns(Guid.NewGuid());
Assert.Equal(0, sutProvider.Sut.GetIntVariation(FeatureFlagKeys.SecretsManager, currentContext)); Assert.Equal(0, sutProvider.Sut.GetIntVariation("somekey", currentContext));
} }
[Fact(Skip = "For local development")] [Fact(Skip = "For local development")]
@ -89,7 +89,7 @@ public class LaunchDarklyFeatureServiceTests
var currentContext = Substitute.For<ICurrentContext>(); var currentContext = Substitute.For<ICurrentContext>();
currentContext.UserId.Returns(Guid.NewGuid()); currentContext.UserId.Returns(Guid.NewGuid());
Assert.Null(sutProvider.Sut.GetStringVariation(FeatureFlagKeys.SecretsManager, currentContext)); Assert.Null(sutProvider.Sut.GetStringVariation("somekey", currentContext));
} }
[Fact(Skip = "For local development")] [Fact(Skip = "For local development")]