nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-07-02 16:42:50 -05:00
Code Activity

[AC-1139] Created new CollectionOperation ReadAccess and changed GetUsers_vNext to use it

Browse Source
This commit is contained in:
Rui Tome
2023-10-30 14:52:37 +00:00
parent 4b293d7ac8
commit bd3d66ab60
3 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Api/Controllers/CollectionsController.cs
View File

@ -566,7 +566,7 @@ public class CollectionsController : Controller
private async Task<IEnumerable<SelectionReadOnlyResponseModel>> GetUsers_vNext(Guid id)
{
var collection = await _collectionRepository.GetByIdAsync(id);
var authorized = (await _authorizationService.AuthorizeAsync(User, collection, CollectionOperations.Read)).Succeeded;
var authorized = (await _authorizationService.AuthorizeAsync(User, collection, CollectionOperations.ReadAccess)).Succeeded;
if (!authorized)
{
throw new NotFoundException();

1
src/Api/Vault/AuthorizationHandlers/Collections/BulkCollectionAuthorizationHandler.cs
View File

@ -84,6 +84,7 @@ public class BulkCollectionAuthorizationHandler : BulkAuthorizationHandler<Colle
break;
case not null when requirement == CollectionOperations.Read:
case not null when requirement == CollectionOperations.ReadAccess:
await CanReadAsync(context, requirement, resources, org);
break;

1
src/Api/Vault/AuthorizationHandlers/Collections/CollectionOperations.cs
View File

@ -19,6 +19,7 @@ public static class CollectionOperations
{
public static readonly CollectionOperationRequirement Create = new() { Name = nameof(Create) };
public static readonly CollectionOperationRequirement Read = new() { Name = nameof(Read) };
public static readonly CollectionOperationRequirement ReadAccess = new() { Name = nameof(ReadAccess) };
public static CollectionOperationRequirement ReadAll(Guid organizationId)
{
return new CollectionOperationRequirement(nameof(ReadAll), organizationId);