1
0
mirror of https://github.com/bitwarden/server.git synced 2025-06-06 19:20:33 -05:00

5902 Commits

Author SHA1 Message Date
Brant DeBow
5e3fcc0225
Add links to different sections; remove inline code formatting in favor of single bacticks for JSON 2025-06-06 10:22:18 -04:00
Brant DeBow
4885c42ed5
Another attempt to fix inline code formatting 2025-06-05 18:38:11 -04:00
Brant DeBow
fee4094f06
Another attempt to fix inline code formatting 2025-06-05 18:27:16 -04:00
Brant DeBow
9e910cae5d
Fix the formatting for inlined code snippets 2025-06-05 18:16:23 -04:00
Brant DeBow
69f8f2b263
Merge branch 'main' into brant/pm-17562-add-technical-documentation-for-event-integrations 2025-06-05 18:03:42 -04:00
Brant DeBow
1ad0d6547a
Updates to README - PR fixes, additional context, tense alignment 2025-06-05 18:03:09 -04:00
aj-bw
25d5efacd8
set 0 when workflow is not ran (#5910) 2025-06-05 14:32:40 -04:00
sneakernuts
ce61a01f29
SRE-2299 cleanup (#5926) 2025-06-05 12:23:01 -06:00
Brant DeBow
06fde72131
Apply suggestions from code review
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2025-06-05 13:52:22 -04:00
cyprain-okeke
acb18c55b3
Resolve the error and consider the free org (#5920) 2025-06-05 18:48:02 +01:00
Matt Bishop
2435063ac8
Move team SQL underneath dbo (#5923) 2025-06-05 12:58:46 -04:00
Brant DeBow
dfa28bc74c
Fix SonarQube suggestion, bring ASB event listener in line with integration listener 2025-06-05 10:08:38 -04:00
Brant DeBow
9b025ef7c2
[PM-17562] Update documentation for event integrations 2025-06-05 09:20:34 -04:00
SmithThe4th
66301bb4dc
[PM-19632] Remove security task flag - step 1 (#5856)
* step 1- remove flag on security task controller

* Fixed lint issues
2025-06-04 16:37:42 -04:00
Jordan Aasen
5c4c06baa0
add restricted item type policy (#5914) 2025-06-04 13:06:52 -07:00
SmithThe4th
ed780d45d3
replace fallback icon default with response (#5878) 2025-06-04 15:25:21 -04:00
Alex Morask
769313abbf
Only set automatic tax to true w/ reverse charge flag if customer has billing location (#5917) 2025-06-04 13:31:17 -05:00
Jordan Aasen
2e14a46cee
[PM-22344] - fix Error: Cannot Decrypt when moving a vault item to a collection (#5911)
* use ToCipher instead of casting

* return ListResponseModel

* fix test

* remove ToArray

* have ShareManyAsync return CipherDetails

* fix test

* fix tests

* fix test

* fix test
2025-06-03 14:02:13 -07:00
renovate[bot]
812fe94c16
[deps]: Update Microsoft.Build.Sql to v1 (#5875)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-06-03 16:41:49 -04:00
aj-bw
6411cc63ca
BRE-875/server-builds-intermittently-failing-after-introducing-build-cache (#5909)
* increase logging

* remove caching for troubleshooting

* test max parallel of 3

* up parallel

* test removing cache again

* add permissions read

* edit permissions
2025-06-03 12:40:46 -04:00
Brant DeBow
59f5fafb87
[PM-17562] Add strict delay support for RabbitMQ; Refactor implementation (#5899)
* [PM-17562] Add strict delay support for RabbitMQ

* fix lint error

* Added more robust FailureReason handling and some additional tests

* Fix two issues noted by SonarQube

* Fix typo; Add alternate handling if MessageId is null or empty

* Set MessageId on all message publishers
2025-06-03 10:48:24 -04:00
Alex Morask
8165651285
Remove pm-18794-provider-payment-method (#5850) 2025-06-03 07:50:52 -05:00
Bernd Schoolmann
14e68428f6
[PM-20225] Block no-userkey legacy users (#5640)
* Block legacy users on all clients over 2025.5

* Update message

* Fix test

* Fix test

* Update blocked version
2025-06-02 22:04:01 +02:00
Henrik
8bac7f0145
[PM-14476] Avoid multiple lookups in dictionaries (#4973)
* Avoid multiple lookups in dictionaries

* Consistency in fallback to empty CollectionIds

* Readability at the cost of lines changed

* Readability

* Changes after running dotnet format
2025-06-02 11:18:28 -05:00
Jordan Aasen
2c4393cc16
[PM-22204] - update cipher/share endpoint to return revision date (#5900)
* return ciper response model in cipher share endpoint. add tests

* return dict instead of full cipher response. adjust specs

* rename vars

* rename vars

* rename vars

* reinsert braces

* add specs

* return CipherMiniResponseModel
2025-06-02 09:05:58 -07:00
Github Actions
8c14630481 Bumped version to 2025.6.0 2025-06-02 15:15:43 +00:00
Daniel James Smith
c7b1c7f6d5
[PM-22190] Remove gathering and reporting of ReferenceEvents (#5897)
* Remove gathering and reporting of ReferenceEvents

* Fix test that relied on reference events throwing

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-06-02 16:49:49 +02:00
Oscar Hinton
d7d90e7f3e
[PM-21079] Add support to integration tests for using sqlserver (#5823)
Adds a SqlServerApiApplicationFactory which allows you to run api tests using SqlServer. Currently a new database is create and destroyed for each test. In the future we'd like a more optimized way to do this.

The database logic is abstracted away in a ITestDatabase interface which handles the configuration, migration and teardown.
2025-06-02 11:06:16 +02:00
tangowithfoxtrot
20105b85aa
fix: failing builds; Setup is no longer a dll (#5901) 2025-05-30 13:28:16 -07:00
tangowithfoxtrot
63f5811aa9
feat: non-root self hosted images for standard deployment (#5701)
* Use IHttpMessageHandlerFactory For HTTP Communication

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>

* feat: allow custom app-id.json location for rootless

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>

* fix: new build context wont allow copying git context

* feat: allow images to run as non-root user

* fix: build failures caused by bad merge

* build: we don't need to copy the `.git` dir

* Revert "build: we don't need to copy the `.git` dir"

This reverts commit 32c2f6236a894534de09ffe847ffff064a7174bd.

* Use `IHttpClientFactory` in more places

* update build workflow

* fix: compatibility with the existin run.sh script

* fix: compatibility with existing run.sh script

* Add SelfHosted GlobalSettings for Setup

* Fix my build error

* Add other services

* Add IConfiguration

* fix: missing gosu command for rootful mode

* fix: try using .net core certificate handling

* fix: add `SSL_CERT_DIR` to remaining images

* Remove X509ChainCustomization activation code

* Revert "Use IHttpMessageHandlerFactory For HTTP Communication"

This reverts commit c93be6d52b12599040d3c3d8a7b3bc854c6c6802.

* Revert "fix: build failures caused by bad merge"

This reverts commit 3e4639489b6b6c06b5a977a069002fe0c0eb2057.

* Revert "Use `IHttpClientFactory` in more places"

This reverts commit 284501a4932b819b093406e0bcdf76def22b6eea.

* remove unused code

* re-add error log for installation id

* remove missing error message in log

* build: remove duplicate docker+qemu setup steps

Co-authored-by: Opeyemi <Alaoopeyemi101@gmail.com>

* build: optimize for simpler builds over caching

* build: restore previous method for getting the GIT_HASH

* fix: add missing build args to remaining images

* fix: rm extraneous source revision id arg

* fmt: apply consistent spacing and rm redundant WORKDIR directive

* build: update migrator to use simpler build; apply consistent spacing

* fix: merge conflicts; simplify changes

* fix: add publish branch check back

---------

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
Co-authored-by: Opeyemi <Alaoopeyemi101@gmail.com>
2025-05-30 10:29:47 -07:00
Justin Baur
0b2b573bd3
Add DynamicClientStore (#5670)
* Add DynamicClientStore

* Formatting

* Fix Debug assertion

* Make Identity internals visible to its unit tests

* Add installation client provider tests

* Add internal client provider tests

* Add DynamicClientStore tests

* Fix namespaces after merge

* Format

* Add docs and remove TODO comments

* Use preferred prefix for API keys

---------

Co-authored-by: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com>
2025-05-30 12:58:54 -04:00
sneakernuts
63f836a73a
SRE-1913 find & replace twitter w/ x (#5586) 2025-05-30 09:58:24 -06:00
Alex Morask
390b93f6ce
[PM-21250] Remove pm-18770-enable-organization-business-unit-conversion (#5848)
* Remove pm-18770-enable-organization-business-unit-conversion

* Run dotnet format
2025-05-30 09:58:36 -04:00
Jared McCannon
d50ad97e6e
Adding OptimizeNestedTraverse feature flag. moved custome role permissions to ac section. (#5853) 2025-05-29 09:57:50 -05:00
Michał Chęciński
3d02d6c4eb
[BRE-826] Update remaining DockerHub references to GitHub (#5877)
* Update README.md to replace Docker Hub links with GitHub Packages links

* Update README.md

Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>

* Remove docker badge

---------

Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
2025-05-29 10:07:46 -04:00
cyprain-okeke
5972ac147e
[PM-21603]Invite Member sub text seat count does not account for sponsorships (#5889)
* Add Occupied Seats at part metadata

* resolve the failing test

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

---------

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
2025-05-29 15:06:25 +01:00
Brandon Treston
930fe29c82
replace owner/admins list with table (#5892) 2025-05-29 09:55:33 -04:00
Brant DeBow
6486354fbc
[PM-17562] Add Azure Service Bus support for event integration retries (#5880)
* [PM-17562] Add Azure Service Bus support for event integration retries

* Cleanup AzureServiceBusIntegrationListenerService.cs; add nullable

* Removed IntegrationHandlerBase* since it is no longer used (We removed the subclasses previously)

* Changed strategy to assume ApplyRetry always gives us a non-null DelayUntilDate; Added test to confirm as well
2025-05-29 08:22:11 -04:00
Rui Tomé
829ce86066
[PM-18238] Add RequireTwoFactorPolicyRequirement (#5840)
* Add RequireTwoFactorPolicyRequirement and its factory with unit tests

* Implemented RequireTwoFactorPolicyRequirement to enforce two-factor authentication policies.
* Created RequireTwoFactorPolicyRequirementFactory to generate policy requirements based on user status.
* Added unit tests for the factory to validate behavior with various user statuses and policy details.

* Enhance AcceptOrgUserCommand to use IPolicyRequirementQuery for two-factor authentication validation

* Update ConfirmOrganizationUserCommand to use RequireTwoFactorPolicyRequirement to check for 2FA requirement

* Implement CanAcceptInvitation and CanBeConfirmed methods in RequireTwoFactorPolicyRequirement; update tests to reflect new logic for two-factor authentication policy handling.

* Refactor AcceptOrgUserCommand to enforce two-factor authentication policy based on feature flag; update validation logic and tests accordingly.

* Enhance ConfirmOrganizationUserCommand to validate two-factor authentication policy based on feature flag; refactor validation logic and update related tests for improved policy handling.

* Remove unused method and its dependencies from OrganizationService.

* Implement CanBeRestored method in RequireTwoFactorPolicyRequirement to determine user restoration eligibility based on two-factor authentication status; add corresponding unit tests for various scenarios.

* Update RestoreOrganizationUserCommand to use IPolicyRequirementQuery for two-factor authentication policies checks

* Remove redundant vNext tests

* Add TwoFactorPoliciesForActiveMemberships property to RequireTwoFactorPolicyRequirement and corresponding unit tests for policy retrieval based on user status

* Refactor UserService to integrate IPolicyRequirementQuery for two-factor authentication policy checks

* Add XML documentation for TwoFactorPoliciesForActiveMemberships property in RequireTwoFactorPolicyRequirement to clarify its purpose and return value.

* Add exception documentation for ValidateTwoFactorAuthenticationPolicyAsync method in ConfirmOrganizationUserCommand to clarify error handling for users without two-step login enabled.

* Update comments in AcceptOrgUserCommand and ConfirmOrganizationUserCommand to clarify handling of two-step login and 2FA policy checks.

* Add RequireTwoFactorPolicyRequirementFactory to PolicyServiceCollectionExtensions

* Refactor two-factor authentication policy checks in AcceptOrgUserCommand and ConfirmOrganizationUserCommand to streamline validation logic and improve clarity. Update RequireTwoFactorPolicyRequirement to provide a method for checking if two-factor authentication is required for an organization. Adjust related unit tests accordingly.

* Add PolicyRequirements namespace

* Update comments in AcceptOrgUserCommand and ConfirmOrganizationUserCommand to clarify two-factor authentication policy requirements and exception handling.

* Refactor RequireTwoFactorPolicyRequirement to return tuples of (OrganizationId, OrganizationUserId) for active memberships requiring two-factor authentication. Update UserService and related tests to reflect this change.

* Refactor AcceptOrgUserCommand: delegate feature flag check to the ValidateTwoFactorAuthenticationPolicyAsync method

* Skip policy check if two-step login is enabled for the user

* Refactor ConfirmOrganizationUserCommand to streamline two-factor authentication policy validation logic

* Refactor AcceptOrgUserCommand to simplify two-factor authentication check by removing intermediate variable

* Update documentation in RequireTwoFactorPolicyRequirement to clarify the purpose of the IsTwoFactorRequiredForOrganization

* Refactor AcceptOrgUserCommandTests to remove redundant two-factor authentication checks and simplify test setup

* Refactor AcceptOrgUserCommand and ConfirmOrganizationUserCommand to streamline two-factor authentication checks by removing redundant conditions and simplifying logic flow.

* Rename removeOrgUserTasks variable in UserService

* Refactor RestoreOrganizationUserCommand to simplify two-factor authentication compliance checks by consolidating logic into a new method, IsTwoFactorRequiredForOrganizationAsync.

* Remove outdated two-factor authentication validation documentation from AcceptOrgUserCommand

* Invert two-factor compliance check in RestoreOrganizationUserCommand to ensure correct validation of organization user policies.

* Refactor UserService to enhance two-factor compliance checks by optimizing organization retrieval and logging when no organizations require two-factor authentication.
2025-05-29 07:40:30 +01:00
Thomas Rittson
c7b0c30370
Bump account revision date in OrgUserRepository (#5884)
Match equivalent MSSQL logic. Also ensures that the revision date
is bumped when the user is revoked.
2025-05-29 07:30:23 +10:00
Todd Martin
fe6181f55f
fix(identity): [PM-21975] Add Security Stamp claim to persisted grant
* Added Security Stamp claim to refresh_token

* Linting

* Added better comments.

* Added clarification to naming of new method.

* Updated comments.

* Added more comments.

* Misspelling
2025-05-28 16:44:18 -04:00
Shane Melton
9ad2d61303
[PM-22146] Remove reference to JSON_PATH_EXISTS for old migration scripts for SH instances running older SQL Server versions (#5894) 2025-05-28 11:31:07 -07:00
Shane Melton
e19bee4195
[PM-22146] Replace JSON_PATH_EXISTS with JSON_QUERY to support older MSSQL versions (#5891) 2025-05-28 10:21:55 -07:00
Github Actions
e241949601 Bumped version to 2025.5.2 2025-05-28 17:04:11 +00:00
aj-bw
1e7d02bca2
BRE-857/collect-code-references-fails-against-tags (#5885)
* update code-references file to also check tags

* fix line
2025-05-28 12:43:15 -04:00
Brandon Treston
cd994f72bf
change verbiage, add column to table (#5888) 2025-05-28 12:06:25 -04:00
cd-bitwarden
31b6b47eac
[PM-20650] Adding feature flag to server for Remove Card Item Type policy (#5830)
* Adding feature flag to server for Remove Card Item Type policy

* Updating new feature flag name
2025-05-28 10:37:10 -04:00
Ike
4f326da8da
[PM- 19438] emergency access docs (#5846)
* doc: adding readme and comments to code for emergency access feature.
* fix: renaming variable names to better match vocabulary around emergency access.
2025-05-28 10:27:34 -04:00
Vince Grassia
fbc8e06c99
Update Renovate config (#5882) 2025-05-27 14:24:31 -04:00
renovate[bot]
359d002881
[deps] Tools: Update MailKit to 4.12.1 (#5881)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2025-05-27 18:59:05 +02:00