Rui Tome
019b39feac
Remove outdated two-factor authentication validation documentation from AcceptOrgUserCommand
2025-05-26 12:20:17 +01:00
Rui Tome
e780ea2526
Refactor RestoreOrganizationUserCommand to simplify two-factor authentication compliance checks by consolidating logic into a new method, IsTwoFactorRequiredForOrganizationAsync.
2025-05-26 12:13:38 +01:00
Rui Tome
1f48b01252
Rename removeOrgUserTasks variable in UserService
2025-05-26 12:12:17 +01:00
Rui Tome
8fc79f26d1
Refactor AcceptOrgUserCommand and ConfirmOrganizationUserCommand to streamline two-factor authentication checks by removing redundant conditions and simplifying logic flow.
2025-05-26 12:11:22 +01:00
Rui Tome
398a542528
Refactor AcceptOrgUserCommandTests to remove redundant two-factor authentication checks and simplify test setup
2025-05-26 11:44:28 +01:00
Rui Tome
fe5180adf5
Update documentation in RequireTwoFactorPolicyRequirement to clarify the purpose of the IsTwoFactorRequiredForOrganization
2025-05-26 11:32:03 +01:00
Rui Tome
1e1d445273
Refactor AcceptOrgUserCommand to simplify two-factor authentication check by removing intermediate variable
2025-05-26 11:26:07 +01:00
Rui Tome
aa73ad31df
Refactor ConfirmOrganizationUserCommand to streamline two-factor authentication policy validation logic
2025-05-26 11:24:08 +01:00
Rui Tome
eeb0b0768f
Skip policy check if two-step login is enabled for the user
2025-05-26 11:22:18 +01:00
Rui Tome
265dd37ca0
Refactor AcceptOrgUserCommand: delegate feature flag check to the ValidateTwoFactorAuthenticationPolicyAsync method
2025-05-26 10:35:10 +01:00
Rui Tome
d98b4b3c4e
Merge branch 'main' into ac/pm-18238/add-requiretwofactorpolicyrequirement
2025-05-26 10:19:03 +01:00
Justin Baur
542941818a
Disallow non ascii in equivalent domain ( #5852 )
...
* Test malicious domain change
* Add tests to detect non-ascii characters
* Revert "Test malicious domain change"
This reverts commit 0602bf6d844b611304aba139e9f49cd38594273a.
* Remove confusing comment from when I was going to detect problems differently
* Update test/Core.Test/Utilities/StaticStoreTests.cs
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
* Update test/Core.Test/Utilities/StaticStoreTests.cs
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
---------
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2025-05-23 10:31:10 -04:00
Rui Tomé
7322e53314
Merge branch 'main' into ac/pm-18238/add-requiretwofactorpolicyrequirement
2025-05-23 14:42:30 +01:00
Rui Tome
2e3056fc2a
Refactor RequireTwoFactorPolicyRequirement to return tuples of (OrganizationId, OrganizationUserId) for active memberships requiring two-factor authentication. Update UserService and related tests to reflect this change.
2025-05-23 14:19:11 +01:00
Rui Tome
705bccae10
Update comments in AcceptOrgUserCommand and ConfirmOrganizationUserCommand to clarify two-factor authentication policy requirements and exception handling.
2025-05-23 13:55:49 +01:00
Rui Tome
04c3896580
Add PolicyRequirements namespace
2025-05-23 12:46:33 +01:00
Rui Tome
7bcf1c1281
Refactor two-factor authentication policy checks in AcceptOrgUserCommand and ConfirmOrganizationUserCommand to streamline validation logic and improve clarity. Update RequireTwoFactorPolicyRequirement to provide a method for checking if two-factor authentication is required for an organization. Adjust related unit tests accordingly.
2025-05-23 12:34:08 +01:00
Thomas Rittson
198d96e155
[PM-21612] [Unified] Fix unhandled error when editing an invited member ( #5817 )
...
* Check for UserId instead of passing potentially default value to
bump account revision date method.
* Pass explicit UserId into CipherRepository.CreateAsync method
used for imports.
2025-05-23 11:45:41 +10:00
Thomas Rittson
83478f9c69
[PM-13274] [Unified] Add integration tests for creating and updating collections ( #5814 )
2025-05-23 11:27:37 +10:00
Matt Gibson
328b84eea0
Add-userid-to-encryption-methods ( #5838 )
...
* Add userId to auth success response
* Validate user that encrypted a cipher matches the user posting the request
* Remove userId from auth success
we don't want to expand this response model
2025-05-22 15:49:14 -04:00
renovate[bot]
77865f071a
[deps] Auth: Lock file maintenance ( #5747 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-22 13:33:46 -04:00
renovate[bot]
34414a0610
[deps] Auth: Update sass to v1.88.0 ( #5684 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ike <137194738+ike-kottlowski@users.noreply.github.com>
2025-05-22 17:02:23 +00:00
renovate[bot]
dd60769499
[deps] Auth: Update bootstrap to v5.3.6 ( #5687 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-22 12:24:55 -04:00
renovate[bot]
ad22f77aba
[deps] Auth: Update webpack to v5.99.8 ( #5728 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-22 11:17:17 -04:00
renovate[bot]
ad8b1d9143
[deps] Auth: Update sass-loader to v16.0.5 ( #5689 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ike <137194738+ike-kottlowski@users.noreply.github.com>
2025-05-22 09:51:38 -04:00
Rui Tome
ee660b25b7
Add RequireTwoFactorPolicyRequirementFactory to PolicyServiceCollectionExtensions
2025-05-22 10:31:08 +01:00
Rui Tome
b20acfe99e
Merge branch 'main' into ac/pm-18238/add-requiretwofactorpolicyrequirement
2025-05-22 10:07:27 +01:00
cyprain-okeke
1ec06faf7d
[PM 21889] 500 Response on POST billing/restart-subscription ( #5851 )
...
* Resolve the 500 errors on restart subscription
* Rename the variable name
2025-05-21 21:28:37 +01:00
Rui Tome
73c6af96b4
Update comments in AcceptOrgUserCommand and ConfirmOrganizationUserCommand to clarify handling of two-step login and 2FA policy checks.
2025-05-21 17:26:31 +01:00
Rui Tome
312f21d4bc
Add exception documentation for ValidateTwoFactorAuthenticationPolicyAsync method in ConfirmOrganizationUserCommand to clarify error handling for users without two-step login enabled.
2025-05-21 16:21:43 +01:00
Rui Tome
f7771e13a5
Add XML documentation for TwoFactorPoliciesForActiveMemberships property in RequireTwoFactorPolicyRequirement to clarify its purpose and return value.
2025-05-21 15:52:04 +01:00
Rui Tome
102c8adf61
Refactor UserService to integrate IPolicyRequirementQuery for two-factor authentication policy checks
2025-05-21 15:49:32 +01:00
Rui Tome
73bf74dac4
Add TwoFactorPoliciesForActiveMemberships property to RequireTwoFactorPolicyRequirement and corresponding unit tests for policy retrieval based on user status
2025-05-21 15:48:46 +01:00
Alex Morask
18d146406c
[PM-21099] (NO LOGIC) Organize Billing provider code ( #5819 )
...
* [NO LOGIC] Organize Billing provider code
* Run dotnet format
* Run dotnet format'
* Fixed using after merge
* Fixed test usings after merge
2025-05-21 09:04:30 -04:00
Alex Morask
e994bf2117
[PM-21383] Use Stripe to get provider pricing for display when feature flag is on ( #5842 )
...
* Use ProviderPriceAdapter when getting provider subscription
* Update test
2025-05-21 08:10:34 -04:00
Rui Tome
1b0632ae52
Remove redundant vNext tests
2025-05-21 10:55:15 +01:00
Rui Tome
a0ffcc81cb
Update RestoreOrganizationUserCommand to use IPolicyRequirementQuery for two-factor authentication policies checks
2025-05-21 10:38:44 +01:00
Vince Grassia
3aa9812353
Fix actionlint issues ( #5841 )
2025-05-20 12:44:01 -04:00
Rui Tome
30490ca383
Implement CanBeRestored method in RequireTwoFactorPolicyRequirement to determine user restoration eligibility based on two-factor authentication status; add corresponding unit tests for various scenarios.
2025-05-20 17:29:54 +01:00
Rui Tome
82188c58e5
Remove unused method and its dependencies from OrganizationService.
2025-05-20 17:09:11 +01:00
Rui Tome
ec81ed786a
Enhance ConfirmOrganizationUserCommand to validate two-factor authentication policy based on feature flag; refactor validation logic and update related tests for improved policy handling.
2025-05-20 16:51:15 +01:00
Rui Tome
02cbdd64a4
Refactor AcceptOrgUserCommand to enforce two-factor authentication policy based on feature flag; update validation logic and tests accordingly.
2025-05-20 16:50:33 +01:00
Rui Tome
f4bfa0baf0
Implement CanAcceptInvitation and CanBeConfirmed methods in RequireTwoFactorPolicyRequirement; update tests to reflect new logic for two-factor authentication policy handling.
2025-05-20 16:47:52 +01:00
Brandon Treston
790173d1c7
remove feature flag ( #5837 )
2025-05-20 10:33:40 -04:00
Rui Tomé
725a793863
[PM-15161] Create ProviderClientOrganizationSignUpCommand command ( #5764 )
...
* Extract OrganizationService.SignupClientAsync into new ResellerClientOrganizationSignUpCommand
* Refactor ResellerClientOrganizationSignUpCommand to remove unused dependencies and simplify SignupClientAsync method signature
* Add unit tests for ResellerClientOrganizationSignUpCommand
* Rename SignUpProviderClientOrganizationCommand
* Rename ProviderClientOrganizationSignUpCommand
* Register ProviderClientOrganizationSignUpCommand for dependency injection
* Refactor ProviderService to use IProviderClientOrganizationSignUpCommand for organization signup process
* Refactor error handling in ProviderClientOrganizationSignUpCommand to use constants for error messages
* Remove SignupClientAsync method from IOrganizationService and OrganizationService, along with associated unit tests
2025-05-20 14:35:47 +01:00
Rui Tome
06a5888c7b
Update ConfirmOrganizationUserCommand to use RequireTwoFactorPolicyRequirement to check for 2FA requirement
2025-05-20 11:19:46 +01:00
Rui Tome
7d817f82af
Merge branch 'main' into ac/pm-18238/add-requiretwofactorpolicyrequirement
...
# Conflicts:
# src/Core/AdminConsole/OrganizationFeatures/OrganizationUsers/AcceptOrgUserCommand.cs
2025-05-20 10:25:45 +01:00
Graham Walker
818934487f
PM-18939 refactoring send service to 'cqrs' ( #5652 )
...
* PM-18939 refactoring send service to 'cqrs'
* PM-18939 fixing import issue with sendValidationService
* PM-18939 fixing code based on PR comments
* PM-18339 reverting to previous code in test
* PM-18939 adding XMLdocs to services
* PM-18939 reverting send validation methods
* PM-18939 updating code to match main
* PM-18939 reverting validateUserCanSaveAsync to match main
* PM-18939 fill our param and return sections of XMLdocs
* PM-18939 updating XMLdocs based on PR comments
* Update src/Core/Tools/SendFeatures/Commands/Interfaces/IAnonymousSendCommand.cs
Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>
* Update src/Core/Tools/SendFeatures/Commands/Interfaces/INonAnonymousSendCommand.cs
Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>
* Update src/Core/Tools/SendFeatures/Commands/Interfaces/INonAnonymousSendCommand.cs
Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>
* Update src/Core/Tools/SendFeatures/Services/Interfaces/ISendStorageService.cs
Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>
* PM-18939 adding commits to change tuple to enum type
* PM-18939 resetting stream position to 0 when uploading file
* PM-18939 updating XMLdocs based on PR comments
* PM-18939 updating XMLdocs
* PM-18939 removing circular dependency
* PM-18939 fixing based on comments
* PM-18939 updating method name and documentation
---------
Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>
2025-05-19 22:59:30 -05:00
Alex Morask
7b3e2a80f4
[PM-21092] Set tax exemption to reverse charge for non-US business-use customers ( #5812 )
...
* Set automatic tax to enabled and tax exempt to reverse where applicable when ff is on
* Fix and add tests
* Run dotnet format
* Run dotnet format
* PM-21745: Resolve defect
* PM-21770: Resolve defect
* Run dotnet format'
2025-05-19 14:53:48 -04:00
Ike
a07cce26f3
[PM-19444] Emergency access device verification email fix ( #5833 )
...
* fix: turn off New Device Verification when emergency access takeover is exercised; Also some Docs
* test: add tests for EmergencyAccessService
2025-05-19 11:59:15 -04:00
