1
0
mirror of https://github.com/bitwarden/server.git synced 2025-04-05 13:08:17 -05:00

5726 Commits

Author SHA1 Message Date
jrmccannon
4e205b9d78
Corrected logic and added more tests. 2025-04-03 07:52:12 -05:00
jrmccannon
e80bbe1caa
Corrected model name. Corrected SM seat calculation. Added test for it. 2025-04-02 20:44:17 -05:00
jrmccannon
739bc65e87
Delayed the hasSecretsManagerStandalone call as long as possible. 2025-04-01 14:35:04 -05:00
jrmccannon
2656ccf314
Created new errors and removed references in business code to ErrorMessages property. This aligns Invite User code to use Errors instead of ErrorMessages 2025-04-01 10:12:14 -05:00
jrmccannon
8e2ac9a5bb
Added test to validate the provider email is sent if org is managed by a provider. 2025-03-31 15:21:29 -05:00
jrmccannon
10901bfeea
Added test around validating the revert. 2025-03-31 15:10:50 -05:00
jrmccannon
58c3864601
Rearranged some things. Fixed the tests. 2025-03-31 10:10:54 -05:00
jrmccannon
5f0d55b472
Merge branch 'main' into jmccannon/ac/pm-16811-scim-invite-optimization
# Conflicts:
#	src/Core/OrganizationFeatures/OrganizationServiceCollectionExtensions.cs
#	test/Core.Test/AdminConsole/Services/OrganizationServiceTests.cs
2025-03-31 08:37:04 -05:00
Jared McCannon
786b0edceb
[PM-18527] - Fix allowing restored user to own multiple free orgs (#5444)
* Moved RestoreUserAsync and RestoreUsersAsync to Command.

* Fixing the bug.

* Added test for bulk method.

* Fixing sonar cube warning.

* SonarQube warning fix.

* Excluding org users we already have.

* Fixed misspelling. Added integration test for method.

* test had the misspelling as well 🤦

* Split out interface. Added admin and confirmed constraints.

* fixed queries and added xml comments and tests.
2025-03-31 08:33:57 -05:00
Daniel García
887332b436
[PM-15127] Remove secrets requirement from build workflow (#5546)
* [PM-15127] Remove secrets requirement from build workflow

* Remove unneeded check, fix target workflow

* Remove IF
2025-03-31 15:19:55 +02:00
Rui Tomé
f60db791cc
[PM-19590] Add k6 load testing script for SyncController's /sync endpoint (#5508)
* Add k6 load testing script for sync endpoint

* Refactor sync response validation to use lowercase keys

* Remove access token validation from sync.js

* Update http_req_duration threshold in sync.js from 400ms to 1200ms
2025-03-31 12:25:36 +01:00
Todd Martin
ad05e3f9e1
Complete feature flag grouping by team (#5574)
* Completed grouping of feature flags by team.

* Completed grouping feature flags by team.

* Linting

* Moved flag.

* Moved ssh-key-vault-item to KM.
2025-03-30 16:03:09 -04:00
Todd Martin
c154b6ad9b
Clean up remove-server-version-header feature flag (#5573)
* Removed feature flag.

* Linting.
2025-03-30 12:57:05 -04:00
jrmccannon
419fbdbced
Merge branch 'main' into jmccannon/ac/pm-16811-scim-invite-optimization
# Conflicts:
#	src/Core/Constants.cs
2025-03-28 14:52:31 -05:00
jrmccannon
eb17fc29fc
Made extension method. 2025-03-28 12:43:33 -05:00
jrmccannon
c987966eee
fixing name of method. 2025-03-28 12:30:14 -05:00
jrmccannon
856374b3b2
Adding error and aligning message. 2025-03-28 12:27:49 -05:00
jrmccannon
e78c9f65b4
Fixing comparison issue. 2025-03-28 12:26:46 -05:00
jrmccannon
65996ae0a9
Renames for organization. 2025-03-28 12:26:06 -05:00
Matt Bishop
6e81cee221
Introduce organization integration configuration details (#5568) 2025-03-28 09:20:35 -07:00
jrmccannon
f8b172ef32
Fixing compiler complaints. 2025-03-28 10:57:20 -05:00
jrmccannon
e86dd00da5
Calculated seat addition for SM. 2025-03-28 10:48:24 -05:00
jrmccannon
06d091178f
Adding XML docs 2025-03-28 10:11:47 -05:00
jrmccannon
1e72072b3a
Fixing compiler complaint. 2025-03-28 10:00:02 -05:00
jrmccannon
750985fafe
Made Revert and Adjust Sm methods consistent. Corrected string comparer. Added comment for revert sm. 2025-03-28 09:57:12 -05:00
jrmccannon
32104a1fe3
Switches to extension method 2025-03-28 09:24:03 -05:00
jrmccannon
a1bd46febf
Using GetPlanOrThrow instead. 2025-03-28 09:10:18 -05:00
jrmccannon
b933007f09
Removed unused classes 2025-03-28 09:09:44 -05:00
jrmccannon
46d36b1ef8
Code Review changes. 2025-03-27 15:38:32 -05:00
Rui Tomé
fb0567b45e
[PM-18523] Add SSO external ID visibility feature flag (#5559) 2025-03-27 14:49:38 +00:00
Thomas Rittson
54f4ba945e
[PM-17558] Remove ShortcutDuplicatePatchRequests feature flag (#5551)
* Delete old command and feature flag switch

* Rename vNext command

* Remove feature flag
2025-03-27 10:13:56 -04:00
jrmccannon
1384d9c58e
fix tests 2025-03-26 16:23:43 -05:00
jrmccannon
75c6d2b0dc
Removed valid wrapper to pass in to validation methods. 2025-03-26 15:57:16 -05:00
jrmccannon
8d2c723c09
Added provider email addresses as well. 2025-03-26 15:37:32 -05:00
jrmccannon
27d6d0d731
Quick rename 2025-03-26 15:30:04 -05:00
jrmccannon
d22cbb27e1
put back in the request for now. 2025-03-26 14:39:55 -05:00
Nick Krantz
6178bb2db1
only create security tasks when a task doesn't exist for the submitted cipher (#5558) 2025-03-26 13:08:19 -05:00
jrmccannon
2f7c0ff1bf
Fixed naming in subscription update models. 2025-03-26 11:18:35 -05:00
jrmccannon
ad3131f66e
Cleaned up DTO models. Moved some validation steps around. A few quick fixes to address CR concerns. Still need to move a few things yet. 2025-03-26 10:56:33 -05:00
Matt Bishop
d4b0058372
Organization integrations and configuration database schemas (#5553)
* Organization integrations and configuration database schemas

* Format EF files
2025-03-26 11:44:05 -04:00
jrmccannon
f3f2f41cfb
Merge branch 'refs/heads/main' into jmccannon/ac/pm-16811-scim-invite-optimization
# Conflicts:
#	test/Core.Test/AdminConsole/Services/OrganizationServiceTests.cs
2025-03-26 10:41:50 -05:00
Bernd Schoolmann
6f227c31e2
Sort km feature flags (#5557) 2025-03-26 15:10:35 +01:00
Rui Tomé
f04a3d638b
[PM-18235] Add PersonalOwnershipPolicyRequirement (#5439)
* Add PersonalOwnershipPolicyRequirement for managing personal ownership policy

* Add tests for PersonalOwnershipPolicyRequirement

* Register PersonalOwnershipPolicyRequirement in policy requirement factory

* Update ImportCiphersCommand to check PersonalOwnershipPolicyRequirement if the PolicyRequirements flag is enabled

Update unit tests

* Update CipherService to support PersonalOwnershipPolicyRequirement with feature flag

- Add support for checking personal ownership policy using PolicyRequirementQuery when feature flag is enabled
- Update CipherService constructor to inject new dependencies
- Add tests for personal vault restrictions with and without feature flag

* Clean up redundant "Arrange", "Act", and "Assert" comments in test methods

* Refactor PersonalOwnershipPolicyRequirementTests method names for clarity

- Improve test method names to better describe their purpose and behavior
- Rename methods to follow a more descriptive naming convention
- No functional changes to the test logic

* Remove commented code explaining policy check

* Refactor PersonalOwnership Policy Requirement implementation

- Add PersonalOwnershipPolicyRequirementFactory to replace static Create method
- Simplify policy requirement creation logic
- Update PolicyServiceCollectionExtensions to register new factory
- Update ImportCiphersCommand to use correct user ID parameter
- Remove redundant PersonalOwnershipPolicyRequirementTests

* Remove redundant PersonalOwnershipPolicyRequirementTests

* Remove unnecessary tests from PersonalOwnershipPolicyRequirementFactoryTests
2025-03-26 09:40:13 +00:00
jrmccannon
e6c3a56c0f
Fixed comment. Fixed multiple enumeration. Changed variable name. 2025-03-25 12:59:41 -05:00
jrmccannon
9b8a15193d
Added groups and collection and users checks. 2025-03-25 12:45:11 -05:00
Nick Krantz
d563f3f78a
Fix logic in text handlebars template (#5542) 2025-03-25 10:16:06 -05:00
Bernd Schoolmann
55980e8038
[PM-16603] Add userkey rotation v2 (#5204)
* Implement userkey rotation v2

* Update request models

* Cleanup

* Update tests

* Improve test

* Add tests

* Fix formatting

* Fix test

* Remove whitespace

* Fix namespace

* Enable nullable on models

* Fix build

* Add tests and enable nullable on masterpasswordunlockdatamodel

* Fix test

* Remove rollback

* Add tests

* Make masterpassword hint optional

* Update user query

* Add EF test

* Improve test

* Cleanup

* Set masterpassword hint

* Remove connection close

* Add tests for invalid kdf types

* Update test/Core.Test/KeyManagement/UserKey/RotateUserAccountKeysCommandTests.cs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Fix formatting

* Update src/Api/KeyManagement/Models/Requests/RotateAccountKeysAndDataRequestModel.cs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update src/Api/Auth/Models/Request/Accounts/MasterPasswordUnlockDataModel.cs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update src/Api/Auth/Models/Request/Accounts/MasterPasswordUnlockDataModel.cs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update src/Api/KeyManagement/Models/Requests/AccountKeysRequestModel.cs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Fix imports

* Fix tests

* Remove null check

* Add rollback

---------

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
2025-03-25 15:23:01 +01:00
jrmccannon
313dbc8616
Corrected double negation. 2025-03-24 15:56:04 -05:00
jrmccannon
99d6413fb8
Updated names. 2025-03-24 15:53:53 -05:00
jrmccannon
6c6ecfefdf
Fixing name. 2025-03-24 15:32:30 -05:00