1
0
mirror of https://github.com/bitwarden/server.git synced 2025-05-08 13:12:16 -05:00

5650 Commits

Author SHA1 Message Date
jrmccannon
6b26333ab8
Rename GetOrganizationsManagingUserAsync to GetOrganizationsClaimingUserAsync.
This renaming clarifies the function's purpose, aligning its name with the concept of "claiming" rather than "managing" user associations.
2025-04-01 15:23:08 -05:00
jrmccannon
766f9b6f0f
Renamed method to improve clarity and consistency.
Replaced `ValidateManagedUserDomainAsync` with `ValidateClaimedUserDomainAsync`.
2025-04-01 15:20:46 -05:00
jrmccannon
cbca2eb1da
Renamed ManagedUserDomainClaimedEmails to ClaimedUserDomainClaimedEmails 2025-04-01 15:15:41 -05:00
Jimmy Vo
f90bcd44de
[PM-19575] Allow enabling Single Org policy when the organization has claimed domains. (#5565) 2025-04-01 10:28:57 -04:00
Vijay Oommen
fd781415c4
[PM-19222] Include UseRiskInsights in license file (#5528) 2025-04-01 16:19:42 +02:00
Todd Martin
1beb5dc5c0
Separate desktop and CLI for ClientType checks (#5441) 2025-04-01 10:06:30 -04:00
Conner Turnbull
0ca1b319fd
Fix PayPal to Stripe credit truncation bug (#5561) 2025-03-31 15:20:31 -04:00
Nick Krantz
9c16127bd4
[PM-14406] Fix security task email sends (#5571)
* convert `AdminOwnerEmails` to List rather than IEnumerable

* check for JSON array in `formatAdminOwnerEmails`

* remove trailing comma for admin/owners

* Use display block on tables to enforce padding

* update padding around review at-risk passwords
2025-03-31 14:00:43 -05:00
Todd Martin
0579fb0e68
[PM-9115] Add feature flag for 2FA persistence (#5583)
* Add new feature flag.

* Clarified name.
2025-03-31 14:27:09 -04:00
renovate[bot]
e7abb07d19
[deps] Tools: Update LaunchDarkly.ServerSdk to 8.7.0 (#5581)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2025-03-31 16:35:59 +00:00
renovate[bot]
a879e4722c
[deps] Tools: Update aws-sdk-net monorepo (#5580)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2025-03-31 16:33:50 +00:00
Conner Turnbull
30ad7d3f73
[PM-18564] Added policy validation before creating or sending org sponsorship invite (#5459)
* Added policy validation before creating or sending org sponsorship invite

* dotnet format strikes again
2025-03-31 12:25:41 -04:00
Jared Snider
683ade9ffc
feat(EF WebAuthnCreds Repo): [Auth/PM-19629] EF WebAuthnCredentialRepository.cs - Rewrite query to avoid reading entire table into memory (#5567) 2025-03-31 09:49:14 -04:00
Jared McCannon
786b0edceb
[PM-18527] - Fix allowing restored user to own multiple free orgs (#5444)
* Moved RestoreUserAsync and RestoreUsersAsync to Command.

* Fixing the bug.

* Added test for bulk method.

* Fixing sonar cube warning.

* SonarQube warning fix.

* Excluding org users we already have.

* Fixed misspelling. Added integration test for method.

* test had the misspelling as well 🤦

* Split out interface. Added admin and confirmed constraints.

* fixed queries and added xml comments and tests.
2025-03-31 08:33:57 -05:00
Daniel García
887332b436
[PM-15127] Remove secrets requirement from build workflow (#5546)
* [PM-15127] Remove secrets requirement from build workflow

* Remove unneeded check, fix target workflow

* Remove IF
2025-03-31 15:19:55 +02:00
Rui Tomé
f60db791cc
[PM-19590] Add k6 load testing script for SyncController's /sync endpoint (#5508)
* Add k6 load testing script for sync endpoint

* Refactor sync response validation to use lowercase keys

* Remove access token validation from sync.js

* Update http_req_duration threshold in sync.js from 400ms to 1200ms
2025-03-31 12:25:36 +01:00
Todd Martin
ad05e3f9e1
Complete feature flag grouping by team (#5574)
* Completed grouping of feature flags by team.

* Completed grouping feature flags by team.

* Linting

* Moved flag.

* Moved ssh-key-vault-item to KM.
2025-03-30 16:03:09 -04:00
Todd Martin
c154b6ad9b
Clean up remove-server-version-header feature flag (#5573)
* Removed feature flag.

* Linting.
2025-03-30 12:57:05 -04:00
Matt Bishop
6e81cee221
Introduce organization integration configuration details (#5568) 2025-03-28 09:20:35 -07:00
Rui Tomé
fb0567b45e
[PM-18523] Add SSO external ID visibility feature flag (#5559) 2025-03-27 14:49:38 +00:00
Thomas Rittson
54f4ba945e
[PM-17558] Remove ShortcutDuplicatePatchRequests feature flag (#5551)
* Delete old command and feature flag switch

* Rename vNext command

* Remove feature flag
2025-03-27 10:13:56 -04:00
Nick Krantz
6178bb2db1
only create security tasks when a task doesn't exist for the submitted cipher (#5558) 2025-03-26 13:08:19 -05:00
Matt Bishop
d4b0058372
Organization integrations and configuration database schemas (#5553)
* Organization integrations and configuration database schemas

* Format EF files
2025-03-26 11:44:05 -04:00
Bernd Schoolmann
6f227c31e2
Sort km feature flags (#5557) 2025-03-26 15:10:35 +01:00
Rui Tomé
f04a3d638b
[PM-18235] Add PersonalOwnershipPolicyRequirement (#5439)
* Add PersonalOwnershipPolicyRequirement for managing personal ownership policy

* Add tests for PersonalOwnershipPolicyRequirement

* Register PersonalOwnershipPolicyRequirement in policy requirement factory

* Update ImportCiphersCommand to check PersonalOwnershipPolicyRequirement if the PolicyRequirements flag is enabled

Update unit tests

* Update CipherService to support PersonalOwnershipPolicyRequirement with feature flag

- Add support for checking personal ownership policy using PolicyRequirementQuery when feature flag is enabled
- Update CipherService constructor to inject new dependencies
- Add tests for personal vault restrictions with and without feature flag

* Clean up redundant "Arrange", "Act", and "Assert" comments in test methods

* Refactor PersonalOwnershipPolicyRequirementTests method names for clarity

- Improve test method names to better describe their purpose and behavior
- Rename methods to follow a more descriptive naming convention
- No functional changes to the test logic

* Remove commented code explaining policy check

* Refactor PersonalOwnership Policy Requirement implementation

- Add PersonalOwnershipPolicyRequirementFactory to replace static Create method
- Simplify policy requirement creation logic
- Update PolicyServiceCollectionExtensions to register new factory
- Update ImportCiphersCommand to use correct user ID parameter
- Remove redundant PersonalOwnershipPolicyRequirementTests

* Remove redundant PersonalOwnershipPolicyRequirementTests

* Remove unnecessary tests from PersonalOwnershipPolicyRequirementFactoryTests
2025-03-26 09:40:13 +00:00
Nick Krantz
d563f3f78a
Fix logic in text handlebars template (#5542) 2025-03-25 10:16:06 -05:00
Bernd Schoolmann
55980e8038
[PM-16603] Add userkey rotation v2 (#5204)
* Implement userkey rotation v2

* Update request models

* Cleanup

* Update tests

* Improve test

* Add tests

* Fix formatting

* Fix test

* Remove whitespace

* Fix namespace

* Enable nullable on models

* Fix build

* Add tests and enable nullable on masterpasswordunlockdatamodel

* Fix test

* Remove rollback

* Add tests

* Make masterpassword hint optional

* Update user query

* Add EF test

* Improve test

* Cleanup

* Set masterpassword hint

* Remove connection close

* Add tests for invalid kdf types

* Update test/Core.Test/KeyManagement/UserKey/RotateUserAccountKeysCommandTests.cs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Fix formatting

* Update src/Api/KeyManagement/Models/Requests/RotateAccountKeysAndDataRequestModel.cs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update src/Api/Auth/Models/Request/Accounts/MasterPasswordUnlockDataModel.cs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update src/Api/Auth/Models/Request/Accounts/MasterPasswordUnlockDataModel.cs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update src/Api/KeyManagement/Models/Requests/AccountKeysRequestModel.cs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Fix imports

* Fix tests

* Remove null check

* Add rollback

---------

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
2025-03-25 15:23:01 +01:00
Matt Andreko
229aecb55c
Update SARIF upload to use proper branch (#5534) 2025-03-24 14:20:42 -04:00
Justin Baur
f1a9545a00
Remove unneeded exclusions (#5478) 2025-03-24 13:48:20 -04:00
Addison Beck
efd33c3301
chore: set correct version for upcoming scheduled release (#5550) 2025-03-24 13:33:51 -04:00
Rui Tomé
24b63f2dcd
[PM-12493] Extract ConfirmUser methods from OrganizationService into commands (#5505)
* Add ConfirmOrganizationUserCommand and IConfirmOrganizationUserCommand interface for managing organization user confirmations

* Add unit tests for ConfirmOrganizationUserCommand to validate user confirmation scenarios

* Register ConfirmOrganizationUserCommand for dependency injection

* Refactor OrganizationUsersController to utilize IConfirmOrganizationUserCommand for user confirmation processes

* Remove ConfirmUserAsync and ConfirmUsersAsync methods from IOrganizationService and OrganizationService

* Rename test methods in ConfirmOrganizationUserCommandTests for clarity and consistency

* Update test method name in ConfirmOrganizationUserCommandTests for improved clarity
2025-03-24 17:05:46 +00:00
Github Actions
d345937ecc Bumped version to 2025.3.6 2025-03-24 11:22:29 +00:00
Github Actions
1db37a14ab Bumped version to 2025.3.5 2025-03-24 10:56:04 +00:00
Github Actions
7eb8ad8fa3 Bumped version to 2025.3.4 2025-03-24 10:49:33 +00:00
Brandon Treston
c7c6528faa
Ac/pm 18240 implement policy requirement for reset password policy (#5521)
* wip

* fix test

* fix test

* refactor

* fix factory method and tests

* cleanup

* refactor

* update copy

* cleanup
2025-03-21 10:07:55 -04:00
Github Actions
5d549402c7 Bumped version to 2025.3.3 2025-03-21 10:15:22 +00:00
Nick Krantz
948d8f707d
[PM-18858] Security Task email bugs (#5536)
* make "Review at-risk passwords" bold

* add owner and admin email address to the bottom of the security notification email

* fix plurality of text email
2025-03-20 14:41:58 -05:00
Github Actions
2d02ad3f61 Bumped version to 2025.3.2 2025-03-20 17:30:55 +00:00
Github Actions
bb674b8990 Bumped version to 2025.3.1 2025-03-20 17:14:35 +00:00
Jared McCannon
f6cc140fde
Switched from .Any to Count. Remove unreachable code. (#5519) 2025-03-20 09:12:39 -05:00
Patrick-Pimentel-Bitwarden
db3151160a
fix(device-approval-persistence): [PM-9112] Device Approval Persistence - Added feature flag. (#5495) 2025-03-19 15:27:51 -04:00
Nick Krantz
3422f4cd50
[PM-18971] Special Characters in Org Names (#5514)
* sanitize organization name for email to avoid encoding

* fix spelling mistake in variable name
2025-03-19 13:55:30 -05:00
Jason Ng
481df89cf0
[PM-19342] Onboarding Nudges Feature Flag (#5530) 2025-03-19 14:24:12 -04:00
Jordan Aasen
21717ec71e
[PM-17733] - [Privilege Escalation] - Unauthorised access allows limited access user to change password of Items (#5452)
* prevent view-only users from updating passwords

* revert change to licensing service

* add tests

* check if organizationId is there

* move logic to private method

* move logic to private method

* move logic into method

* revert change to licensing service

* throw exception when cipher key is created by hidden password users

* fix tests

* don't allow totp or passkeys changes from hidden password users

* add tests

* revert change to licensing service
2025-03-19 11:13:38 -07:00
Todd Martin
fc827ed209
feat(set password) [PM-17647] Add set/change password feature flags
* Added flag values

* Added flag values

* Removed extra space

* Linting
2025-03-19 13:49:02 -04:00
Rui Tomé
bb3ec6aca1
[PM-16888] Refactor OrganizationUser status update procedure to use a GuidIdArray parameter and remove JSON parsing logic (#5237)
* Refactor OrganizationUser status update procedure to use a GuidIdArray parameter and remove JSON parsing logic

* Fix OrganizationUser_SetStatusForUsersById procedure and bump script date

* Restore OrganizationUser_SetStatusForUsersById for possible server version rollback. Add new version with the name OrganizationUser_SetStatusForUsersByGuidIdArray

* Add migration script to add stored procedure OrganizationUser_SetStatusForUsersByGuidIdArray to update user status by GUID array
2025-03-19 11:01:06 +00:00
Vince Grassia
7f0dd6d1c3
Update FROM directive in Dockerfile (#5522) 2025-03-18 20:02:39 +00:00
renovate[bot]
508bf2c9f8
[deps] Vault: Update AngleSharp to 1.2.0 (#5220)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-18 14:26:29 -04:00
Alex Morask
87cdb923a5
[PM-17901] Replaced hard-coded Bitwarden Vault URLs (#5458)
* Replaced hard-coded Bitwarden Vault URLs

* Jared's feedback
2025-03-18 11:44:36 -04:00
renovate[bot]
43d0f1052b
[deps] Tools: Update MailKit to 4.11.0 (#5515)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-18 14:04:54 +01:00