1
0
mirror of https://github.com/bitwarden/server.git synced 2025-07-05 18:12:48 -05:00
Commit Graph

5692 Commits

Author SHA1 Message Date
75c6d2b0dc Removed valid wrapper to pass in to validation methods. 2025-03-26 15:57:16 -05:00
8d2c723c09 Added provider email addresses as well. 2025-03-26 15:37:32 -05:00
27d6d0d731 Quick rename 2025-03-26 15:30:04 -05:00
d22cbb27e1 put back in the request for now. 2025-03-26 14:39:55 -05:00
2f7c0ff1bf Fixed naming in subscription update models. 2025-03-26 11:18:35 -05:00
ad3131f66e Cleaned up DTO models. Moved some validation steps around. A few quick fixes to address CR concerns. Still need to move a few things yet. 2025-03-26 10:56:33 -05:00
f3f2f41cfb Merge branch 'refs/heads/main' into jmccannon/ac/pm-16811-scim-invite-optimization
# Conflicts:
#	test/Core.Test/AdminConsole/Services/OrganizationServiceTests.cs
2025-03-26 10:41:50 -05:00
6f227c31e2 Sort km feature flags (#5557) 2025-03-26 15:10:35 +01:00
f04a3d638b [PM-18235] Add PersonalOwnershipPolicyRequirement (#5439)
* Add PersonalOwnershipPolicyRequirement for managing personal ownership policy

* Add tests for PersonalOwnershipPolicyRequirement

* Register PersonalOwnershipPolicyRequirement in policy requirement factory

* Update ImportCiphersCommand to check PersonalOwnershipPolicyRequirement if the PolicyRequirements flag is enabled

Update unit tests

* Update CipherService to support PersonalOwnershipPolicyRequirement with feature flag

- Add support for checking personal ownership policy using PolicyRequirementQuery when feature flag is enabled
- Update CipherService constructor to inject new dependencies
- Add tests for personal vault restrictions with and without feature flag

* Clean up redundant "Arrange", "Act", and "Assert" comments in test methods

* Refactor PersonalOwnershipPolicyRequirementTests method names for clarity

- Improve test method names to better describe their purpose and behavior
- Rename methods to follow a more descriptive naming convention
- No functional changes to the test logic

* Remove commented code explaining policy check

* Refactor PersonalOwnership Policy Requirement implementation

- Add PersonalOwnershipPolicyRequirementFactory to replace static Create method
- Simplify policy requirement creation logic
- Update PolicyServiceCollectionExtensions to register new factory
- Update ImportCiphersCommand to use correct user ID parameter
- Remove redundant PersonalOwnershipPolicyRequirementTests

* Remove redundant PersonalOwnershipPolicyRequirementTests

* Remove unnecessary tests from PersonalOwnershipPolicyRequirementFactoryTests
2025-03-26 09:40:13 +00:00
e6c3a56c0f Fixed comment. Fixed multiple enumeration. Changed variable name. 2025-03-25 12:59:41 -05:00
9b8a15193d Added groups and collection and users checks. 2025-03-25 12:45:11 -05:00
d563f3f78a Fix logic in text handlebars template (#5542) 2025-03-25 10:16:06 -05:00
55980e8038 [PM-16603] Add userkey rotation v2 (#5204)
* Implement userkey rotation v2

* Update request models

* Cleanup

* Update tests

* Improve test

* Add tests

* Fix formatting

* Fix test

* Remove whitespace

* Fix namespace

* Enable nullable on models

* Fix build

* Add tests and enable nullable on masterpasswordunlockdatamodel

* Fix test

* Remove rollback

* Add tests

* Make masterpassword hint optional

* Update user query

* Add EF test

* Improve test

* Cleanup

* Set masterpassword hint

* Remove connection close

* Add tests for invalid kdf types

* Update test/Core.Test/KeyManagement/UserKey/RotateUserAccountKeysCommandTests.cs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Fix formatting

* Update src/Api/KeyManagement/Models/Requests/RotateAccountKeysAndDataRequestModel.cs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update src/Api/Auth/Models/Request/Accounts/MasterPasswordUnlockDataModel.cs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update src/Api/Auth/Models/Request/Accounts/MasterPasswordUnlockDataModel.cs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update src/Api/KeyManagement/Models/Requests/AccountKeysRequestModel.cs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Fix imports

* Fix tests

* Remove null check

* Add rollback

---------

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
2025-03-25 15:23:01 +01:00
313dbc8616 Corrected double negation. 2025-03-24 15:56:04 -05:00
99d6413fb8 Updated names. 2025-03-24 15:53:53 -05:00
6c6ecfefdf Fixing name. 2025-03-24 15:32:30 -05:00
f69dc1f7cf Moved XML comment. Added check to see if additional seats are needed. 2025-03-24 15:24:22 -05:00
229aecb55c Update SARIF upload to use proper branch (#5534) 2025-03-24 14:20:42 -04:00
f1a9545a00 Remove unneeded exclusions (#5478) 2025-03-24 13:48:20 -04:00
038c00d21f PasswordManagerInviteUserValidation to PasswordManagerInviteUserValidator 2025-03-24 12:39:03 -05:00
f0770eda93 Rename for InvitingUserOrganizationValidation to InvitingUserOrganizationValidator 2025-03-24 12:35:16 -05:00
982611bd1b Renamed InviteUsersValidation to InviteUsersValidator 2025-03-24 12:34:36 -05:00
efd33c3301 chore: set correct version for upcoming scheduled release (#5550) 2025-03-24 13:33:51 -04:00
5f41d1eb23 Variable/Field/Property renames 2025-03-24 12:33:02 -05:00
44b817ad03 Separated old and new code explicitly. Moved old code checks down into new code as well. Added error and mapper to Failure<T> 2025-03-24 12:07:28 -05:00
24b63f2dcd [PM-12493] Extract ConfirmUser methods from OrganizationService into commands (#5505)
* Add ConfirmOrganizationUserCommand and IConfirmOrganizationUserCommand interface for managing organization user confirmations

* Add unit tests for ConfirmOrganizationUserCommand to validate user confirmation scenarios

* Register ConfirmOrganizationUserCommand for dependency injection

* Refactor OrganizationUsersController to utilize IConfirmOrganizationUserCommand for user confirmation processes

* Remove ConfirmUserAsync and ConfirmUsersAsync methods from IOrganizationService and OrganizationService

* Rename test methods in ConfirmOrganizationUserCommandTests for clarity and consistency

* Update test method name in ConfirmOrganizationUserCommandTests for improved clarity
2025-03-24 17:05:46 +00:00
7be2e2bd07 Removed test only constructor from InviteOrganization 2025-03-24 08:45:19 -05:00
d345937ecc Bumped version to 2025.3.6 2025-03-24 11:22:29 +00:00
1db37a14ab Bumped version to 2025.3.5 2025-03-24 10:56:04 +00:00
7eb8ad8fa3 Bumped version to 2025.3.4 2025-03-24 10:49:33 +00:00
3f81e15169 fixed test 2025-03-21 15:54:03 -05:00
87c181b662 Refactor validation parameter to improve clarity and consistency. Added XML doc 2025-03-21 15:18:05 -05:00
e1eb458036 Made public method private. added some comments. 2025-03-21 14:43:07 -05:00
d867b47705 Merge branch 'refs/heads/main' into jmccannon/ac/pm-16811-scim-invite-optimization
# Conflicts:
#	src/Core/AdminConsole/Services/Implementations/OrganizationService.cs
2025-03-21 13:50:22 -05:00
c7c6528faa Ac/pm 18240 implement policy requirement for reset password policy (#5521)
* wip

* fix test

* fix test

* refactor

* fix factory method and tests

* cleanup

* refactor

* update copy

* cleanup
2025-03-21 10:07:55 -04:00
5d549402c7 Bumped version to 2025.3.3 2025-03-21 10:15:22 +00:00
948d8f707d [PM-18858] Security Task email bugs (#5536)
* make "Review at-risk passwords" bold

* add owner and admin email address to the bottom of the security notification email

* fix plurality of text email
2025-03-20 14:41:58 -05:00
2d02ad3f61 Bumped version to 2025.3.2 2025-03-20 17:30:55 +00:00
bb674b8990 Bumped version to 2025.3.1 2025-03-20 17:14:35 +00:00
f6cc140fde Switched from .Any to Count. Remove unreachable code. (#5519) 2025-03-20 09:12:39 -05:00
829e49c398 Fixed tests. 2025-03-20 09:11:09 -05:00
a2b155e81c Made HasSecretsManagerStandalone return if org doesn't have sm. Added overload for lighter weight model and moved common code to private method. 2025-03-20 09:06:34 -05:00
edbf1cea41 fixing test. 2025-03-19 18:42:08 -05:00
db3151160a fix(device-approval-persistence): [PM-9112] Device Approval Persistence - Added feature flag. (#5495) 2025-03-19 15:27:51 -04:00
3422f4cd50 [PM-18971] Special Characters in Org Names (#5514)
* sanitize organization name for email to avoid encoding

* fix spelling mistake in variable name
2025-03-19 13:55:30 -05:00
481df89cf0 [PM-19342] Onboarding Nudges Feature Flag (#5530) 2025-03-19 14:24:12 -04:00
21717ec71e [PM-17733] - [Privilege Escalation] - Unauthorised access allows limited access user to change password of Items (#5452)
* prevent view-only users from updating passwords

* revert change to licensing service

* add tests

* check if organizationId is there

* move logic to private method

* move logic to private method

* move logic into method

* revert change to licensing service

* throw exception when cipher key is created by hidden password users

* fix tests

* don't allow totp or passkeys changes from hidden password users

* add tests

* revert change to licensing service
2025-03-19 11:13:38 -07:00
fc827ed209 feat(set password) [PM-17647] Add set/change password feature flags
* Added flag values

* Added flag values

* Removed extra space

* Linting
2025-03-19 13:49:02 -04:00
5b87fa629e Cleaned up return. 2025-03-19 12:15:16 -05:00
0565755e4e Added throwing of Failure as the previous implementation would have. 2025-03-19 11:49:56 -05:00