nhyatt/go-junit-report
1
0
Fork 0
mirror of https://github.com/jstemmer/go-junit-report.git synced 2025-04-05 13:08:07 -05:00
Code Issues Projects Releases Wiki Activity

internal/gojunitreport: Refactor testFileConfig to drop else block

Browse Source
This commit is contained in:
Joël Stemmer 2022-08-11 00:49:55 +01:00
parent ddf6b16828
commit 0fc43a220a
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
internal/gojunitreport/go-junit-report_test.go
View File

@ -86,12 +86,12 @@ func testRun(inputFile, reportFile string, config Config, t *testing.T) {
} }
func testFileConfig(filename string) (config Config, reportFile string, err error) { func testFileConfig(filename string) (config Config, reportFile string, err error) {
var prefix string idx := strings.IndexByte(filename, '-')
if idx := strings.IndexByte(filename, '-'); idx < 0 { if idx < 0 {
return config, "", fmt.Errorf("testdata file does not contain a dash (-); expected name `{id}-{name}.txt` got `%s`", filename) return config, "", fmt.Errorf("testdata file does not contain a dash (-); expected name `{id}-{name}.txt` got `%s`", filename)
} else {
prefix = filename[:idx]
} }
prefix := filename[:idx]
id, err := strconv.Atoi(prefix) id, err := strconv.Atoi(prefix)
if err != nil { if err != nil {
return config, "", fmt.Errorf("testdata file did not start with a valid number: %w", err) return config, "", fmt.Errorf("testdata file did not start with a valid number: %w", err)