nhyatt/go-junit-report
1
0
Fork 0
mirror of https://github.com/jstemmer/go-junit-report.git synced 2025-04-05 05:00:15 -05:00
Code Issues Projects Releases Wiki Activity

Remove custom properties parsed from test output

Browse Source 
In the future it will be possible to add your own properties via
commandline flags.
This commit is contained in:
Joël Stemmer 2022-03-13 21:26:28 +00:00
parent 01c1e1fc30
commit 334044509c
2 changed files with 0 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
go-junit-report_test.go
View File

@ -205,8 +205,6 @@ func testReport(input, reportFile, packageName string, t *testing.T) {
testTime := time.Date(2022, 1, 1, 0, 0, 0, 0, time.UTC)
actual := gtr.JUnit(gtr.FromEvents(events, packageName), "hostname", testTime)
// Remove any new properties for backwards compatibility
actual = dropNewProperties(actual)
expectedXML, err := loadTestReport(reportFile, "")
if err != nil {
@ -242,20 +240,6 @@ func modifyForBackwardsCompat(testsuites junit.Testsuites) junit.Testsuites {
return testsuites
}
func dropNewProperties(testsuites junit.Testsuites) junit.Testsuites {
for i, suite := range testsuites.Suites {
if suite.Properties == nil {
continue
}
ps := suite.Properties
ps = dropProperty("goos", ps)
ps = dropProperty("goarch", ps)
ps = dropProperty("pkg", ps)
testsuites.Suites[i].Properties = ps
}
return testsuites
}
func dropProperty(name string, properties *[]junit.Property) *[]junit.Property {
if properties == nil {
return nil

11
pkg/gtr/gtr.go
View File

@ -10,11 +10,6 @@ import (
"github.com/jstemmer/go-junit-report/v2/pkg/junit"
)
var (
propPrefixes = map[string]bool{"goos": true, "goarch": true, "pkg": true}
propFieldsFunc = func(r rune) bool { return r == ':' || r == ' ' }
)
type Report struct {
Packages []Package
}
@ -126,12 +121,6 @@ func JUnit(report Report, hostname string, now time.Time) junit.Testsuites {
suite.AddProperty("coverage.statements.pct", fmt.Sprintf("%.2f", pkg.Coverage))
}
for _, line := range pkg.Output {
if fields := strings.FieldsFunc(line, propFieldsFunc); len(fields) == 2 && propPrefixes[fields[0]] {
suite.AddProperty(fields[0], fields[1])
}
}
for _, test := range pkg.Tests {
duration += test.Duration