nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-04-09 23:28:06 -05:00
Code Issues Projects Releases Wiki Activity

Add missing casts in dupcat().

Browse Source 
Ahem. I _spotted_ this in code review, and forgot to make the change
before pushing!

Because it's legitimate for a C implementation to define 'NULL' so
that it expands to just 0, it follows that if you use NULL in a
variadic argument list where the callee will expect to extract a
pointer, you run the risk of putting an int-sized rather than
pointer-sized argument on the list and causing the consumer to get out
of sync. So you have to add an explicit cast.
This commit is contained in:
Simon Tatham 2018-02-13 19:45:54 +00:00
parent 3447047594
commit 31a2017af5
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
unix/gtkdlg.c
View File

@ -3960,7 +3960,7 @@ void showeventlog(void *estuff, void *parentwin)
c->listbox.percentages[2] = 65;
es->window = window = our_dialog_new();
title = dupcat(appname, " Event Log", NULL);
title = dupcat(appname, " Event Log", (const char *)NULL);
gtk_window_set_title(GTK_WINDOW(window), title);
sfree(title);
w0 = layout_ctrls(&es->dp, &es->scs, s0, GTK_WINDOW(window));

2
windows/windlg.c
View File

@ -779,7 +779,7 @@ void logevent(void *frontend, const char *string)
if (*location)
sfree(*location);
*location = dupcat(timebuf, string, NULL);
*location = dupcat(timebuf, string, (const char *)NULL);
if (logbox) {
int count;
SendDlgItemMessage(logbox, IDN_LIST, LB_ADDSTRING,