mirror of
https://git.tartarus.org/simon/putty.git
synced 2025-01-08 08:58:00 +00:00
Add missing del234 in ssh_transient_hostkey_cache_add.
The idea was that if we found a host key already cached for the given algorithm, we should remove it from the tree and free it. In fact, I forgot the 'remove from tree' step, so we freed a key that was still linked from the tree234. Depending on luck and platform, this could either cause a segfault, or an assertion failure on the subsequent attempt to add the new key in place of the not-removed-after-all old one.
This commit is contained in:
parent
29cb7e40eb
commit
67881a129c
@ -76,6 +76,7 @@ void ssh_transient_hostkey_cache_add(
|
||||
|
||||
if ((ent = find234(thc->cache, (void *)ssh_key_alg(key),
|
||||
ssh_transient_hostkey_cache_find)) != NULL) {
|
||||
del234(thc->cache, ent);
|
||||
strbuf_free(ent->pub_blob);
|
||||
sfree(ent);
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user