nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-09 17:38:00 +00:00
Code Issues Projects Releases Wiki Activity

openssh-certs: Avoid C99 strftime() specifiers.

Browse Source 
These were introduced in 34d01e1b65 to pretty-print certificate validity
ranges. But Microsoft's C runtime took a while to catch up with C99 --
stackoverflow claims that VS2013 and earlier don't support these
specifiers -- so it's possible to end up with PuTTY executables that
misdisplay these dates. Also, the mingw-w64 toolchain's -Wformat
complains about these specifiers, at least on Debian buster, presumably
for the same reason.

Since the specifiers in question have exact pre-C99 replacements, it
seems easiest just to use those.
This commit is contained in:
Jacob Nevins 2022-08-30 17:27:50 +01:00
parent baea34a5b2
commit d2e982efa7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crypto/openssh-certs.c
View File

@ -581,7 +581,7 @@ static void opensshcert_time_to_iso8601(BinarySink *bs, uint64_t time)
time_t t = time;
char buf[256];
put_data(bs, buf, strftime(buf, sizeof(buf),
"%a %F %T %Z", localtime(&t)));
"%a %Y-%m-%d %H:%M:%S %Z", localtime(&t)));
}
static void opensshcert_string_list_key_components(